Correctly exclude the Helix Job Monitor stage in coreclr outerloop - #132882
Merged
Merged
Conversation
github-actions
Bot
added
the
area-Infrastructure-coreclr
|
Azure Pipelines: Successfully started running 4 pipeline(s). 12 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Member
Author
|
/ba-g Killing the monitor asap to reduce load on AzDO |
premun
enabled auto-merge (squash)
August 28, 2026 10:44
virekumar
approved these changes
Aug 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CoreCLR outerloop Azure Pipelines definition to conditionally include the Helix Job Monitor job template only when enableHelixJobMonitor is enabled, instead of always injecting the monitor job.
Changes:
- Wraps the
helix-job-monitor.ymljob template inclusion in a compile-time conditional (${{ if ... }}) driven byenableHelixJobMonitor. - Leaves the existing
enableHelixJobMonitor: falsedefault in this pipeline, so the monitor job is excluded by default for this definition.
akoeplinger
approved these changes
Aug 28, 2026
Member
Author
|
/backport to release/11.0 |
Contributor
|
Started backporting to |
akoeplinger
added a commit
that referenced
this pull request
Sep 21, 2026
## Description Backport the Helix job monitor integration from main/release/11.0, including the groundwork from #129690 and #132150 and the re-enablement in #131969. Includes the subsequent fixes for empty stages (#132019), conditional monitor inclusion (#132882, #132884), parameter forwarding (#133002), performance monitoring (#132807, #133480), and internal credentials (#133633, #133688, #133885). - Use `Microsoft.DotNet.Helix.JobMonitor` version `10.0.0-beta.26461.103`, matching release/10.0's existing Arcade/VMR build. - Preserve the existing SDK, shared Arcade templates, queues, and release/10.0 job layouts. - Follow upstream enablement, except scheduled libraries outerloop runs retain release/10.0's existing warning-only reporting policy. - Leave SuperPMI's post-Helix processing unchanged. The separate perf-slow enablement in #133726 is not included. ## Customer Impact CI infrastructure only; no shipped runtime changes. Moves Helix waiting and test-result reporting into the standalone monitor for the enabled pipelines. ## Regression Not a product regression fix; backports existing CI infrastructure and its follow-up fixes. ## Testing - Validated YAML/JSON/XML configuration and preservation of unrelated settings. - Checked 43 entry pipelines, 149 forwarding sites, and 516 public/internal, PR/scheduled/manual, and normal/staging combinations, plus disabled-mode behavior. - Exercised MSBuild child-property forwarding and the pinned SDK's waiting/reporter properties, including environment-based opt-in. - Restored the monitor and verified its CLI compatibility under .NET 10. No product build or live Azure DevOps pipeline execution was performed locally. ## Risk Changes CI scheduling and result reporting, not product behavior. Uses the monitor package matching the branch's existing toolset and retains the release/10.0-specific scheduled outerloop failure policy. End-to-end Azure DevOps validation is still required. > [!NOTE] > This PR description and backport were prepared with GitHub Copilot. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: aae9b201-32a8-45eb-ae1a-db80a0ab4156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.