Skip to content

Reactivate closed-issue Extensions tests #132740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
svick merged 3 commits into from
Sep 3, 2026
Merged

Reactivate closed-issue Extensions tests #132740

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4fef7e6
Reactivate closed-issue Extensions tests
svick Aug 25, 2026
b5a2c6b
Keep warn-as-error generator test disabled
svick Aug 25, 2026
4ea5354
Re-disable browser test failures
svick Aug 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ...s/Microsoft.Extensions.Configuration.Binder/tests/SourceGenerationTests/GeneratorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@

namespace Microsoft.Extensions.SourceGeneration.Configuration.Binder.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/52062", TestPlatforms.Browser)]
public partial class ConfigurationBindingGeneratorTests : ConfigurationBinderTestsBase
{
[Theory]
Expand Down
1 change: 0 additions & 1 deletion .../Microsoft.Extensions.Configuration.FileExtensions/tests/FileConfigurationProviderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ public void ProviderDisposesChangeTokenRegistration()

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/52319", TestPlatforms.Android)]
public void ProviderThrowsInvalidDataExceptionWhenLoadFails()
{
var tempFile = Path.GetTempFileName();
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/Microsoft.Extensions.Configuration.Ini/tests/IniConfigurationExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ public class IniConfigurationExtensionsTest
[Theory]
[InlineData(null)]
[InlineData("")]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50867", TestPlatforms.Android)]
public void AddIniFile_ThrowsIfFilePathIsNullOrEmpty(string? path)
{
// Arrange
Expand All @@ -26,7 +25,6 @@ public void AddIniFile_ThrowsIfFilePathIsNullOrEmpty(string? path)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50867", TestPlatforms.Android)]
public void AddIniFile_ThrowsIfFileDoesNotExistAtPath()
{
// Arrange
Expand Down
1 change: 0 additions & 1 deletion src/libraries/Microsoft.Extensions.Configuration.Ini/tests/IniConfigurationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,7 +251,6 @@ public void ThrowExceptionWhenKeyIsDuplicated()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50867", TestPlatforms.Android)]
public void IniConfiguration_Throws_On_Missing_Configuration_File()
{
var exception = Assert.Throws<FileNotFoundException>(() => new ConfigurationBuilder().AddIniFile("NotExistingConfig.ini").Build());
Expand Down
2 changes: 1 addition & 1 deletion src/libraries/Microsoft.Extensions.Configuration.Xml/tests/XmlConfigurationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -726,9 +726,9 @@ public void XmlConfiguration_Does_Not_Throw_On_Optional_Configuration()
var config = new ConfigurationBuilder().AddXmlFile("NotExistingConfig.xml", optional: true).Build();
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/73432", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/37669", TestPlatforms.Browser)]
[Fact]
public void LoadKeyValuePairsFromValidEncryptedXml()
{
var xml = @"
Expand Down
2 changes: 0 additions & 2 deletions ...Microsoft.Extensions.DependencyInjection/tests/DI.Tests/ServiceProviderCompilationTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

namespace Microsoft.Extensions.DependencyInjection.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/33894", TestRuntimes.Mono)]
public class ServiceProviderCompilationTest
{
// Runs the compilation on a dedicated thread with a small stack size, which requires multithreading support.
Expand All @@ -19,7 +18,6 @@ public class ServiceProviderCompilationTest
[InlineData(ServiceProviderMode.Runtime, typeof(I999))]
[InlineData(ServiceProviderMode.ILEmit, typeof(I999))]
[InlineData(ServiceProviderMode.Expressions, typeof(I999))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/33894", TestRuntimes.Mono)]
private async Task CompilesInLimitedStackSpace(ServiceProviderMode mode, Type serviceType)
{
// Arrange
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/Microsoft.Extensions.DependencyModel/tests/DependencyContextJsonReaderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,6 @@ public void ReadsRuntimeTargetInfo(bool withPreamble)
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50872", TestPlatforms.Android)]
public void ReadsRuntimeTargetInfoWithCommentsIsInvalid()
{
var exception = Assert.ThrowsAny<JsonException>(() => Read(
Expand Down Expand Up @@ -308,7 +307,6 @@ public void ReadsCompilationTarget()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50872", TestPlatforms.Android)]
public void RejectsMissingLibrary()
{
var exception = Assert.Throws<InvalidOperationException>(() => Read(
Expand Down
1 change: 0 additions & 1 deletion src/libraries/Microsoft.Extensions.Hosting/tests/UnitTests/HostTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,6 @@ public void LastCallToUseEnvironmentWins(string environment)
}

[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsMultithreadingSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/48696")]
public async Task CreateDefaultBuilder_ConfigJsonDoesNotReload()
{
var reloadFlagConfig = new Dictionary<string, string>() { { "hostbuilder:reloadConfigOnChange", "false" } };
Expand Down
3 changes: 0 additions & 3 deletions ...nsions.Http/tests/Microsoft.Extensions.Http.Tests/DefaultHttpMessageHandlerBuilderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,6 @@ public void Build_SomeAdditionalHandlers_PutsTogetherDelegatingHandlers()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50873", TestPlatforms.Android)]
public void Build_PrimaryHandlerIsNull_UsesDefault()
{
// Arrange
Expand All @@ -101,7 +100,6 @@ public void Build_PrimaryHandlerIsNull_UsesDefault()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50873", TestPlatforms.Android)]
public void Build_AdditionalHandlerIsNull_ThrowsException()
{
// Arrange
Expand All @@ -120,7 +118,6 @@ public void Build_AdditionalHandlerIsNull_ThrowsException()

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50873", TestPlatforms.Android)]
public void Build_AdditionalHandlerHasNonNullInnerHandler_ThrowsException()
{
// Arrange
Expand Down
1 change: 0 additions & 1 deletion ...nsions.Http.Tests/DependencyInjection/HttpClientFactoryServiceCollectionExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ public void AddHttpClient_RegistersDefaultClientAsHttpClient()
}

[Fact] // Verifies that AddHttpClient does not override any existing registration
[ActiveIssue("https://github.com/dotnet/runtime/issues/50873", TestPlatforms.Android)]
public void AddHttpClient_DoesNotRegisterDefaultClientIfAlreadyRegistered()
{
// Arrange
Expand Down
2 changes: 0 additions & 2 deletions ...ft.Extensions.Http/tests/Microsoft.Extensions.Http.Tests/HttpMessageHandlerBuilderTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ public class HttpMessageHandlerBuilderTest
{
// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50873", TestPlatforms.Android)]
public void Build_AdditionalHandlerIsNull_ThrowsException()
{
// Arrange
Expand All @@ -32,7 +31,6 @@ public void Build_AdditionalHandlerIsNull_ThrowsException()

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50873", TestPlatforms.Android)]
public void Build_AdditionalHandlerHasNonNullInnerHandler_ThrowsException()
{
// Arrange
Expand Down
1 change: 0 additions & 1 deletion ...tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorEmitterTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@

namespace Microsoft.Extensions.Logging.Generators.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/52062", TestPlatforms.Browser)]
public class LoggerMessageGeneratorEmitterTests
{
[Fact]
Expand Down
1 change: 0 additions & 1 deletion .../tests/Microsoft.Extensions.Logging.Generators.Tests/LoggerMessageGeneratorParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@

namespace Microsoft.Extensions.Logging.Generators.Tests
{
[ActiveIssue("https://github.com/dotnet/runtime/issues/52062", TestPlatforms.Browser)]
public class LoggerMessageGeneratorParserTests
{
[Fact]
Expand Down
6 changes: 0 additions & 6 deletions src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerFactoryExtensionsTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ public class LoggerFactoryExtensionsTest
{
// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34091", TestRuntimes.Mono)]
public void LoggerFactoryCreateOfT_CallsCreateWithCorrectName()
{
// Arrange
Expand All @@ -32,7 +31,6 @@ public void LoggerFactoryCreateOfT_CallsCreateWithCorrectName()

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34091", TestRuntimes.Mono)]
public void LoggerFactoryCreateOfT_SingleGeneric_CallsCreateWithCorrectName()
{
// Arrange
Expand All @@ -49,7 +47,6 @@ public void LoggerFactoryCreateOfT_SingleGeneric_CallsCreateWithCorrectName()

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34091", TestRuntimes.Mono)]
public void LoggerFactoryCreateOfT_TwoGenerics_CallsCreateWithCorrectName()
{
// Arrange
Expand Down Expand Up @@ -121,7 +118,6 @@ public void CreatesLoggerName_OnMultipleTypeArgumentGenericType_CreatesWithoutGe

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34091", TestRuntimes.Mono)]
public void LoggerFactoryCreate_CallsCreateWithCorrectName()
{
// Arrange
Expand All @@ -141,7 +137,6 @@ public void LoggerFactoryCreate_CallsCreateWithCorrectName()

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34091", TestRuntimes.Mono)]
public void LoggerFactoryCreate_SingleGeneric_CallsCreateWithCorrectName()
{
// Arrange
Expand All @@ -158,7 +153,6 @@ public void LoggerFactoryCreate_SingleGeneric_CallsCreateWithCorrectName()

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34091", TestRuntimes.Mono)]
public void LoggerFactoryCreate_TwoGenerics_CallsCreateWithCorrectName()
{
// Arrange
Expand Down
1 change: 0 additions & 1 deletion src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerFilterTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,6 @@ public void DefaultCategoryIsCaseInsensitive()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50875", TestPlatforms.Android)]
public void MultipleWildcardsAreNotAllowed()
{
var options = new LoggerFilterOptions()
Expand Down
4 changes: 0 additions & 4 deletions src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerMessageTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -254,7 +254,6 @@ public void LogMessage_WithNullParameter_DoesNotMutateArgument()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50875", TestPlatforms.Android)]
public void DefineMessage_WithNoParameters_ThrowsException_WhenFormatString_HasNamedParameters()
{
// Arrange
Expand All @@ -276,7 +275,6 @@ public void DefineMessage_WithNoParameters_ThrowsException_WhenFormatString_HasN
[InlineData(4)]
[InlineData(5)]
[InlineData(6)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50875", TestPlatforms.Android)]
public void DefineMessage_ThrowsException_WhenExpectedFormatStringParameterCount_NotFound(
int expectedNamedParameterCount)
{
Expand Down Expand Up @@ -321,7 +319,6 @@ public void DefineMessage_ThrowsException_WhenExpectedFormatStringParameterCount
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50875", TestPlatforms.Android)]
public void DefineScope_WithNoParameters_ThrowsException_WhenFormatString_HasNamedParameters()
{
// Arrange
Expand All @@ -343,7 +340,6 @@ public void DefineScope_WithNoParameters_ThrowsException_WhenFormatString_HasNam
[InlineData(4)]
[InlineData(5)]
[InlineData(6)]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50875", TestPlatforms.Android)]
public void DefineScope_ThrowsException_WhenExpectedFormatStringParameterCount_NotFound(
int expectedNamedParameterCount)
{
Expand Down
4 changes: 0 additions & 4 deletions src/libraries/Microsoft.Extensions.Logging/tests/Common/LoggerTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ public void LoggerCanGetProviderAfterItIsCreated()

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34091", TestRuntimes.Mono)]
public void ScopesAreNotCreatedForDisabledLoggers()
{
var provider = new Mock<ILoggerProvider>();
Expand All @@ -153,7 +152,6 @@ public void ScopesAreNotCreatedForDisabledLoggers()

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34091", TestRuntimes.Mono)]
public void ScopesAreNotCreatedWhenScopesAreDisabled()
{
var provider = new Mock<ILoggerProvider>();
Expand All @@ -179,7 +177,6 @@ public void ScopesAreNotCreatedWhenScopesAreDisabled()

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34091", TestRuntimes.Mono)]
public void ScopesAreNotCreatedInIScopeProviderWhenScopesAreDisabled()
{
var provider = new Mock<ILoggerProvider>();
Expand Down Expand Up @@ -213,7 +210,6 @@ public void ScopesAreNotCreatedInIScopeProviderWhenScopesAreDisabled()

// Moq heavily utilizes RefEmit, which does not work on most aot workloads
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsReflectionEmitSupported))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34091", TestRuntimes.Mono)]
public void CaptureScopesIsReadFromConfiguration()
{
var provider = new Mock<ILoggerProvider>();
Expand Down
2 changes: 0 additions & 2 deletions ...rosoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsFactoryTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,6 @@ public void CanMixConfigureEverything()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50877", TestPlatforms.Android)]
public void ConfigureOptionsThrowsWithAction()
{
var services = new ServiceCollection();
Expand All @@ -361,7 +360,6 @@ public void ConfigureOptionsThrowsWithAction()
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/50877", TestPlatforms.Android)]
public void ConfigureOptionsThrowsIfNothingFound()
{
var services = new ServiceCollection();
Expand Down
Loading