DispatchResolve: Avoid clobbering t1 in RhpInterfaceDispatch - #132134
Merged
Merged
Conversation
The `tail` pseudo-instruction expands to auipc t1 + jalr t1, which destroys the dispatch cell address just placed in t1 as the thunk target's parameter. Perform the tail jump manually through t2 instead, matching what RhpInterfaceDispatchSlow does in StubDispatch.S. Signed-off-by: Maxim Menshikov <maksim.menshikov@nethermind.io>
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
Author
|
@am11 @filipnavara could you take a look? |
|
Azure Pipelines: Successfully started running 3 pipeline(s). 13 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
Contributor
Author
|
similar to this PR: |
jkotas
reviewed
Aug 12, 2026
jkotas
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tailpseudo-instruction expands to auipc t1 + jalr t1, which destroys the dispatch cell address just placed in t1 as the thunk target's parameter. Perform the tail jump manually through t2 instead, matching what RhpInterfaceDispatchSlow does in StubDispatch.S.