Reapply "Add lane construction and composition APIs" - #129627
Merged
Merged
Conversation
dotnet-policy-service
Bot
added
the
community-contribution
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the System.Runtime.Intrinsics test suite to cover newly introduced vector “sequence” helpers (geometric/alternating/harmonic/sign) and lane composition APIs (zip/unzip/concat/reverse) across multiple vector widths.
Changes:
- Adds
CreateGeometricSequence,CreateAlternatingSequence, andCreateHarmonicSequencetest coverage forVector64/256/512. - Adds
SignSequencevalidation for signed/floating element types. - Adds lane-operation tests validating
Zip*,Unzip*,Concat*, andReversebehavior (including Vector64 count==1 edge cases for 64-bit lanes).
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/libraries/System.Runtime.Intrinsics/tests/Vectors/Vector64Tests.cs | Adds tests for new sequence APIs, sign sequence, and lane composition ops (incl. count==1 semantics for 64-bit lanes). |
| src/libraries/System.Runtime.Intrinsics/tests/Vectors/Vector256Tests.cs | Adds tests for new sequence APIs, sign sequence, and lane composition ops for Vector256<T>. |
| src/libraries/System.Runtime.Intrinsics/tests/Vectors/Vector512Tests.cs | Adds tests for new sequence APIs, sign sequence, and lane composition ops for Vector512<T>. |
tannergooding
approved these changes
Jun 19, 2026
EgorBo
approved these changes
Jun 19, 2026
eiriktsarpalis
pushed a commit
that referenced
this pull request
Jul 15, 2026
Redo "Add lane construction and composition APIs", and add NYI to wasm SIMD path. cc: @tannergooding
ManickaP
pushed a commit
to ManickaP/runtime
that referenced
this pull request
Jul 22, 2026
Redo "Add lane construction and composition APIs", and add NYI to wasm SIMD path. cc: @tannergooding
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redo "Add lane construction and composition APIs", and add NYI to wasm SIMD path.
cc: @tannergooding