[browser] upgrade wasm exceptions by pavelsavara · Pull Request #129396 · dotnet/runtime

pavelsavara · 2026-06-14T17:44:12Z

TODO: https://gist.github.com/pavelsavara/f43aa98501c64bede3d031a3ce88a3cf,
depends on docker image with the new V8 - #129396

(cherry picked from commit ea0ec7c)

When passing a negative C int to LLVMConstInt, the value is implicitly converted to unsigned long long via sign-extension. In LLVM 23, LLVMConstInt now retains those upper bits when SignExtend is FALSE, which broke constant folding of subsequent ZExt instructions (e.g. 'zext i32 -1 to i64' produced i64 -1 instead of i64 4294967295). This manifested as wrong results for decimal arithmetic in mono+LLVM AOT, e.g. the inlined Decimal..ctor(uint) with a constant argument sign-extending to _lo64. Many CoreLib tests (System.Tests.DecimalTests, System.Text.Tests.RuneTests, Vector128.NarrowWithSaturation*) were failing as a result. Mask the value to the destination width before passing to LLVMConstInt. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…), not the legacy one

Updated comments to clarify that OSX HFS driver format does not support millisecond granularity.

LLVMConstInt(IntTy, N, FALSE) requires N to fit in IntTy's unsigned width (i.e. no bits set beyond IntTy's bit count). Passing -1 (= 0xFF..FF as unsigned long long) to a sub-64-bit type violates this. Under LLVM 23 the resulting constant is wrong, which in emit_div_check caused the rhs == -1 comparison to constant-fold to false and the OverflowException check for INT_MIN / -1 and INT_MIN % -1 to be eliminated by the optimizer. Use LLVMConstAllOnes() which is the LLVM C API's idiomatic way to build an all-ones constant of any integer width, sidestepping the issue. Also fix the same pattern in emit_entry_bb where il_state->il_offset is initialized to -1. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

for wasm-opt: --enable-reference-types --enable-multivalue for runtime default build: new instructions -fwasm-exceptions -sWASM_LEGACY_EXCEPTIONS=0 for no-EH runtime:-fexceptions JS exceptions

- change jiterp to use new wasm exception instructions

# Conflicts: # src/tests/JIT/Regression/CLR-x86-JIT/V1.1-M1-Beta1/b143840/b143840.il

…o emsdk-upgrade

# Conflicts: # eng/pipelines/runtime-llvm.yml # src/mono/mono/metadata/assembly-load-context.c

Classify managed (<=16 byte, non-pinvoke) value types whose fields straddle the 8-byte eightbyte boundary as ArgValuetypeInReg instead of forcing them onto the stack. This makes a partially-shared (gshared) caller -- which sees the value as an opaque type parameter with one straddling field -- agree with a concrete callee that sees the flattened layout, in both the JIT and the LLVM backend, fixing the miscompile recent LLVM exposed under Mono LLVM full-AOT. Replaces the LLVM-only llvm_inreg_straddle approach with a layout-independent classification and removes the bitfield and its get_llvm_call_info special-case. Adds a StructABI regression test covering the gshared box/unbox, all-integer and float straddlers, direct by-value pass, and register GC-safety.

…_exceptions # Conflicts: # eng/pipelines/runtime-llvm.yml # src/mono/mono/mini/mini-amd64.c

Copilot

Pull request overview

Copilot reviewed 64 out of 66 changed files in this pull request and generated 4 comments.

+    <!-- TEMPORARY: pinned to the staged emsdk 5.0.6 SDK build on the ci.dot.net/dev feed (only 11.0.100-preview.6.26314.102 is staged there).
+         WorkloadTesting.Core.targets installs the SDK at this version from ci.dot.net/dev; do NOT follow
+         $(MicrosoftNETWorkloadEmscriptenCurrentManifest110100TransportVersion): merges from main bump it past the staged build,
+         and that SDK exists on neither ci.dot.net/dev nor production (dotnet-install fails, MSB3073).
+         Repin to the production .NET 11 emsdk 5.0.6 manifest transport (and drop the ci.dot.net/dev wiring) before merge. See dotnet/runtime#113786. -->
+    <_DotnetSdkVersion>11.0.100-preview.6.26314.102</_DotnetSdkVersion>
    <SdkVersionForWorkloadTesting Condition="$([System.String]::Compare('$(_GlobalJsonSdkVersion)', '$(_DotnetSdkVersion)')) &lt;= 0">$(_DotnetSdkVersion)</SdkVersionForWorkloadTesting>


+    <!-- TEMPORARY: pinned to the staged emsdk 5.0.6 workload manifest in the general-testing feed.
+         NOTE: this is the emscripten workload MANIFEST version and uses the sdk feature-band format (11.0.100-preview.6.*),
+         NOT the runtime format (11.0.0-preview.6.*) used by EmsdkPackageVersion below; both share the 26314.102 build stamp.
+         Do NOT restore to $(MicrosoftDotNetApiCompatTaskPackageVersion): merges from main bump it past the staged manifest
+         and break the workload install (NU1102 on Microsoft.NET.Workload.Emscripten.Current.Manifest-11.0.100-preview.6).
+         Repin to the production .NET 11 emsdk 5.0.6 version (and drop the general-testing feed) before merge. See dotnet/runtime#113786. -->
+    <MicrosoftNETRuntimeEmscriptenVersion>11.0.100-preview.6.26314.102</MicrosoftNETRuntimeEmscriptenVersion>
    <!-- we're using MicrosoftNETCoreAppRefPackageVersion since the emsdk package ID contains a changing version. This one uses runtime version numbers.  -->
-    <EmsdkPackageVersion>$(MicrosoftNETCoreAppRefPackageVersion)</EmsdkPackageVersion>
+    <!-- TEMPORARY: pinned to the staged emsdk 5.0.6 packages (Microsoft.NET.Runtime.Emscripten.5.0.6.Cache/Sdk.*) in the general-testing feed, which only
+         exist at 11.0.0-preview.6.26314.102. Do NOT restore to $(MicrosoftNETCoreAppRefPackageVersion): merges from main bump it past the staged build
+         and break native build restore (NU1102). Repin to the production .NET 11 emsdk 5.0.6 transport (and drop the general-testing feed) before merge. -->
+    <EmsdkPackageVersion>11.0.0-preview.6.26314.102</EmsdkPackageVersion>
    <NodePackageVersion>$(runtimewinx64MicrosoftNETCoreRuntimeWasmNodeTransportPackageVersion)</NodePackageVersion>
    <!-- The package path for python in src/mono/mono.proj needs to be updated if this changes-->
-    <EmsdkVersion>3.1.56</EmsdkVersion>
+    <EmsdkVersion>5.0.6</EmsdkVersion>


+    <!-- Replace ci.dot.net/public with ci.dot.net/dev in the script using the platform's native tools.
+         This avoids MSBuild's string/item-list parsing pitfalls (e.g. ';' splitting in WriteLinesToFile,
+         line-ending and escaping issues) when round-tripping an entire shell/PowerShell script through
+         MSBuild properties. We're already invoking these shells right after, so leverage them directly. -->
+    <Message Text="** Replacing ci.dot.net/public with ci.dot.net/dev in $(_DotNetInstallScriptPath)" Importance="High" />
+
+    <Exec Condition="!$([MSBuild]::IsOSPlatform('windows'))"
+          IgnoreStandardErrorWarningFormat="true"
+          Command="sed -i.bak 's|ci\.dot\.net/public|ci.dot.net/dev|g' &quot;$(_DotNetInstallScriptPath)&quot; &amp;&amp; rm -f &quot;$(_DotNetInstallScriptPath).bak&quot;" />
+    <Exec Condition="$([MSBuild]::IsOSPlatform('windows'))"
+          IgnoreStandardErrorWarningFormat="true"
+          Command='powershell -ExecutionPolicy ByPass -NoProfile -Command "(Get-Content -Raw -LiteralPath &apos;$(_DotNetInstallScriptPath)&apos;).Replace(&apos;ci.dot.net/public&apos;, &apos;ci.dot.net/dev&apos;) | Set-Content -NoNewline -LiteralPath &apos;$(_DotNetInstallScriptPath)&apos;"' />
+


    <add key="dotnet11" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet11/nuget/v3/index.json" />
    <add key="dotnet11-transport" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet11-transport/nuget/v3/index.json" />
    <add key="dotnet-diagnostics-tests" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-diagnostics-tests/nuget/v3/index.json" />
+    <add key="general-testing" value="https://pkgs.dev.azure.com/dnceng/public/_packaging/general-testing/nuget/v3/index.json" />
  </packageSources>


pavelsavara · 2026-06-24T20:28:04Z

/azp run runtime-wasm

azure-pipelines · 2026-06-24T20:28:24Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2026-06-24T20:28:41Z

/azp run runtime-extra-platforms

azure-pipelines · 2026-06-24T20:28:59Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2026-06-24T20:41:10Z

/azp run runtime-extra-platforms

pavelsavara · 2026-06-24T20:41:24Z

/azp run runtime-wasm

azure-pipelines · 2026-06-24T20:41:26Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines · 2026-06-24T20:41:35Z

Azure Pipelines successfully started running 1 pipeline(s).

lock_free_mempool_chunk_new sized each chunk by reserving sizeof(LockFreeMempoolChunk) (24 bytes on 64-bit), but chunk->mem is then aligned up to 16 bytes, so the usable region starts at offset 32 and a single-page chunk only has pagesize-32 usable bytes. A request whose length is congruent to -24 (mod pagesize) - e.g. 4072 on 4 KB pages, 16360 on 16 KB pages - produced a freshly allocated chunk whose size (pagesize-32) is smaller than the requested length, tripping g_assert (chunk->pos + size <= GINT_TO_UINT(chunk->size)); in lock_free_mempool_alloc0 and aborting the runtime. This pool is used on the async AOT unwind/exception-info decode path (mono_aot_get_unwind_info / decode_exception_debug_info with async==TRUE), which is driven by the EventPipe SampleProfiler stack walk, so the crash showed up intermittently as a SIGABRT during eventpipe tracing tests under Mono LLVM full-AOT on x64. Fix: reserve the 16-byte-aligned header size in the sizing loop so the chunk always has room for the request.

Copilot

Pull request overview

Copilot reviewed 65 out of 67 changed files in this pull request and generated 2 comments.

    prepareAssetsWorker();
    const promises = importModules();
    const es6Modules = await Promise.all(promises);
+    (globalThis as any).name = "em-pthread";


+    <!-- TEMPORARY: pinned to the staged emsdk 5.0.6 SDK build on the ci.dot.net/dev feed (only 11.0.100-preview.6.26314.102 is staged there).
+         WorkloadTesting.Core.targets installs the SDK at this version from ci.dot.net/dev; do NOT follow
+         $(MicrosoftNETWorkloadEmscriptenCurrentManifest110100TransportVersion): merges from main bump it past the staged build,
+         and that SDK exists on neither ci.dot.net/dev nor production (dotnet-install fails, MSB3073).
+         Repin to the production .NET 11 emsdk 5.0.6 manifest transport (and drop the ci.dot.net/dev wiring) before merge. See dotnet/runtime#113786. -->
+    <_DotnetSdkVersion>11.0.100-preview.6.26314.102</_DotnetSdkVersion>
    <SdkVersionForWorkloadTesting Condition="$([System.String]::Compare('$(_GlobalJsonSdkVersion)', '$(_DotnetSdkVersion)')) &lt;= 0">$(_DotnetSdkVersion)</SdkVersionForWorkloadTesting>


akoeplinger and others added 30 commits June 11, 2026 18:44

Upgrade emsdk to 5.0.6

af4402c

Add general-testing feed

64a07bf

rebase

5c431c3

(cherry picked from commit ea0ec7c)

Remove lbulkmemory

1cc4928

Update to llvm 23.x

f0619f9

Fix llvm version check in src/mono/CMakeLists.txt

ea8bd08

Fix llvm warnings/errors

813760c

Don't mark Browser as LowTemporalResolution anymore

b6e6b73

don't node flush streams in a browser

4113f8e

export memory from Module

fa8db40

Update llvm

64eaad9

balance clearTimeout

3bcf4d0

balance runtimeKeepalivePop

0dab167

WASM_BIGINT=0 for node testing

5ad201d

fix WasmEnableExceptionHandling=false

8c992af

improve sample

273e1e1

Use the standardized Wasm EH proposal (exnref / try_table / throw_ref…

95feacd

…), not the legacy one

Refine comments regarding millisecond granularity support

a374f19

Updated comments to clarify that OSX HFS driver format does not support millisecond granularity.

Update llvm

938a82e

disable WASM_BIGINT for corerun - NodeJS

53a6d16

for nodejs: --experimental-wasm-exnref

6860d5c

for wasm-opt: --enable-reference-types --enable-multivalue for runtime default build: new instructions -fwasm-exceptions -sWASM_LEGACY_EXCEPTIONS=0 for no-EH runtime:-fexceptions JS exceptions

- change wasm exception instructions detection

d38a699

- change jiterp to use new wasm exception instructions

bump nodejs

65e869a

kg feedback

25cf5ae

Merge branch 'main' into emsdk-upgrade

5a9bb28

v8 --experimental-wasm-exnref

09623f5

Bump FireFox to 140.11.0esr

7f3a839

Update llvm

720eeb7

pavelsavara and others added 9 commits June 24, 2026 18:36

Merge branch 'main' into emsdk-upgrade

4160a65

# Conflicts: # src/tests/JIT/Regression/CLR-x86-JIT/V1.1-M1-Beta1/b143840/b143840.il

Bump node versions

ba575b0

Revert assembly-load-context.c - keep it in dotnet#129693

73aa77c

Merge branch 'emsdk-upgrade' of https://github.com/dotnet/runtime int…

9755a4e

…o emsdk-upgrade

Merge branch 'emsdk-upgrade' into emsdk-upgrade-wasm_exceptions

bdd55c9

# Conflicts: # eng/pipelines/runtime-llvm.yml # src/mono/mono/metadata/assembly-load-context.c

Merge branch 'main' into emsdk-upgrade-wasm_exceptions

da8612b

Merge branch 'main' into mono-amd64-llvm-straddle-vtype

6e7d28d

Merge branch 'mono-amd64-llvm-straddle-vtype' into emsdk-upgrade-wasm…

ad3572d

…_exceptions # Conflicts: # eng/pipelines/runtime-llvm.yml # src/mono/mono/mini/mini-amd64.c

Copilot AI review requested due to automatic review settings June 24, 2026 18:54

Copilot started reviewing on behalf of pavelsavara June 24, 2026 18:54 View session

Copilot AI reviewed Jun 24, 2026

View reviewed changes

fix MT sample

5958e93

Copilot AI mentioned this pull request Jun 24, 2026

Fix flaky SendAsync_Success_ConnectionSetupActivityGraphRecorded test (Http1.1 + Http2) #129822

Closed

build-analysis Bot mentioned this pull request Jun 25, 2026

SOSStackAndOtherTests are failing #129820

Closed

Copilot AI review requested due to automatic review settings June 25, 2026 10:45

Copilot started reviewing on behalf of pavelsavara June 25, 2026 10:45 View session

Copilot AI reviewed Jun 25, 2026

View reviewed changes

pavelsavara closed this Jun 25, 2026

pavelsavara mentioned this pull request Jun 25, 2026

[browser] Use the new version of V8 with --experimental-wasm-exnref #129849

Open

build-analysis Bot mentioned this pull request Jun 25, 2026

Flaky timeout in CreateFileChangeToken_RootDeletedAndRecreated_TokenFiresWhenFileCreated #129691

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[browser] upgrade wasm exceptions#129396

[browser] upgrade wasm exceptions#129396
pavelsavara wants to merge 176 commits into
dotnet:mainfrom
pavelsavara:emsdk-upgrade-wasm_exceptions

pavelsavara commented Jun 14, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

pavelsavara commented Jun 24, 2026

Uh oh!

azure-pipelines Bot commented Jun 24, 2026

Uh oh!

pavelsavara commented Jun 24, 2026

Uh oh!

azure-pipelines Bot commented Jun 24, 2026

Uh oh!

pavelsavara commented Jun 24, 2026

Uh oh!

pavelsavara commented Jun 24, 2026

Uh oh!

azure-pipelines Bot commented Jun 24, 2026

Uh oh!

azure-pipelines Bot commented Jun 24, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

pavelsavara commented Jun 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

pavelsavara commented Jun 24, 2026

Uh oh!

azure-pipelines Bot commented Jun 24, 2026

Uh oh!

pavelsavara commented Jun 24, 2026

Uh oh!

azure-pipelines Bot commented Jun 24, 2026

Uh oh!

pavelsavara commented Jun 24, 2026

Uh oh!

pavelsavara commented Jun 24, 2026

Uh oh!

azure-pipelines Bot commented Jun 24, 2026

Uh oh!

azure-pipelines Bot commented Jun 24, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pavelsavara commented Jun 14, 2026 •

edited

Loading