Skip to content

Pre-initialize InvariantCulture such that it can be safely used when creating stack traces #129189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eduardo-vp wants to merge 4 commits into
base: main
Choose a base branch
from
+7 −0
Open

Pre-initialize InvariantCulture such that it can be safely used when creating stack traces #129189

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a4ac39c
Pre-initialize InvariantCulture
Jun 9, 2026
fe0e038
Move to CreateAppDomainWithManager
Jun 10, 2026
d26c8ac
Fix placement
Jun 10, 2026
e67a9ba
Merge branch 'main' into fix-129159
eduardo-vp Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/coreclr/vm/corhost.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -615,6 +615,13 @@ HRESULT CorHost2::CreateAppDomainWithManager(
sAppPaths));
}

{
// Initialize the InvariantCulture such that it can be safely used when creating
// stack traces under high memory pressure.
GCX_COOP();

@jkotas jkotas Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
GCX_COOP();

Is GCX_COOP really needed here?

CheckRunClassInitThrowing seems to be MODE_ANY. It may be nice to add it to its contract to be make it explicit.

@jkotas jkotas Jun 16, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related nit: GCX_COOP in ResolveVirtualFunctionPointer around CheckRunClassInitThrowing looks unnecessary It can be deleted.

CoreLibBinder::GetClass(CLASS__CULTURE_INFO)->CheckRunClassInitThrowing();
}

#if defined(TARGET_UNIX) && !defined(FEATURE_STATICALLY_LINKED)
if (!g_coreclr_embedded)
{
Expand Down