Disable SystemCoreLibDirectory on ReadyToRun#129178
Merged
Merged
Conversation
This test copies SPC.dll to a custom path and then tests that it is able to load it from this path, instead of the default path. The problem is when the framework is R2R compiled in composite mode. The new SPC.dll will point to the composite image. This tweaked SPC.dll gets copied to another location where the loading of the R2R image fails. I believe the runtime crashing here is the right behavior and tweaking the test to copy framework-r2r.dll as well seems like overkill.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the CoreCLR loader test SystemCoreLibDirectory to opt out of CrossGen2 / ReadyToRun test runs, based on the test’s reliance on redirecting System.Private.CoreLib.dll to a different directory.
Changes:
- Mark the
SystemCoreLibDirectorytest project as not eligible for CrossGen2/R2R runs by setting<CrossGenTest>false</CrossGenTest>.
This was referenced Jun 9, 2026
Open
elinor-fung
approved these changes
Jun 9, 2026
Member
Author
|
/ba-g infra failure |
This was referenced Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test copies SPC.dll to a custom path and then tests that it is able to load it from this path, instead of the default path. The problem is when the framework is R2R compiled in composite mode. The new SPC.dll will point to the composite image. This tweaked SPC.dll gets copied to another location where the loading of the R2R image fails. I believe the runtime crashing here is the right behavior and tweaking the test to copy framework-r2r.dll as well seems like overkill.