Skip to content

Fix CS9361 stackalloc unsafe context in X25519DiffieHellmanCng #127999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vcsjones merged 4 commits into from
May 10, 2026
+7 −1
Merged

Fix CS9361 stackalloc unsafe context in X25519DiffieHellmanCng #127999

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bd97fd
Initial plan
Copilot May 9, 2026
603fbb8
Fix CS9361 stackalloc unsafe context in X25519DiffieHellmanCng
Copilot May 9, 2026
84b0c3b
Use 'unsafe' modifier on DeriveRawSecretAgreementCore partial method …
Copilot May 9, 2026
38bba78
Use scoped Span<byte> with unsafe block instead of unsafe modifier
Copilot May 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion ....Security.Cryptography/src/System/Security/Cryptography/X25519DiffieHellmanCng.Windows.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,13 @@ protected override partial void DeriveRawSecretAgreementCore(X25519DiffieHellman
{
// We intentionally don't special case otherParty being an instance of X25519DiffieHellmanCng and always
// export the public key into the current instance's provider.
Span<byte> publicKeyBuffer = stackalloc byte[PublicKeySizeInBytes * 2];
scoped Span<byte> publicKeyBuffer;

unsafe
{
publicKeyBuffer = stackalloc byte[PublicKeySizeInBytes * 2];
}

Span<byte> publicKeyBytes = publicKeyBuffer.Slice(0, PublicKeySizeInBytes);
Span<byte> reducedPublicKey = publicKeyBuffer.Slice(PublicKeySizeInBytes, PublicKeySizeInBytes);
otherParty.ExportPublicKey(publicKeyBytes);
Expand Down
Loading