Skip to content

Arm64 jitstress outerloop#126736

Merged
dhartglassMSFT merged 1 commit into
dotnet:mainfrom
dhartglassMSFT:fix_jitstress_arm64_outerloop
Apr 10, 2026
Merged

Arm64 jitstress outerloop#126736
dhartglassMSFT merged 1 commit into
dotnet:mainfrom
dhartglassMSFT:fix_jitstress_arm64_outerloop

Conversation

@dhartglassMSFT

@dhartglassMSFT dhartglassMSFT commented Apr 10, 2026

Copy link
Copy Markdown
Contributor

Original fix here missed some cases, as msbuild or helix cuts off the failure list after 300:

95f94b6

This is applying the same fix to other locations we needed this.

I grabbed this codechange from @ylpoonlg (thanks in advance)

Ran jitstress, arm64 is green

Copilot AI review requested due to automatic review settings April 10, 2026 00:24
@github-actions github-actions Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Apr 10, 2026
@dhartglassMSFT

Copy link
Copy Markdown
Contributor Author

/azp run runtime-coreclr jitstress2-jitstressregs

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts ARM64 JIT HWIntrinsic codegen to correctly account for multi-instruction expansion in RMW-style SVE intrinsics when generating non-constant-immediate jump tables. This aligns the HWIntrinsicImmOpHelper case-size calculation with the emitter’s behavior under register-stress scenarios (e.g., targetReg != op1Reg).

Changes:

  • Pass an explicit numInstrs to HWIntrinsicImmOpHelper for SVE saturating inc/dec-by-element-count codegen when the emitter may insert an extra move.
  • Pass an explicit numInstrs to HWIntrinsicImmOpHelper for NI_Sve_ExtractVector to match the emitter’s RMW handling (may require a move when targetReg != op1Reg).

Comment thread src/coreclr/jit/hwintrinsiccodegenarm64.cpp
@dhartglassMSFT

Copy link
Copy Markdown
Contributor Author

Arm64 jitstress is clean on all arm64 including windows+linux (the ones that test SVE2)

android is crit: Failed to find compatible device: arm64-v8a, unrelated
x86 jitstressregs is existing failure, unrelated
NameResolution tests have open issue, unrelated

@dhartglassMSFT dhartglassMSFT merged commit 1584123 into dotnet:main Apr 10, 2026
160 of 165 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators May 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants