Skip to content

SPMI: Fix invalid format string and allow parsing full uint32 range #125874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jakobbotsch merged 3 commits into from
Mar 30, 2026
Merged

SPMI: Fix invalid format string and allow parsing full uint32 range #125874

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68d717e
SPMI fix
jakobbotsch Mar 20, 2026
e9a62d1
Apply suggestion from @jakobbotsch
jakobbotsch Mar 20, 2026
a10305f
Apply suggestion from @jakobbotsch
jakobbotsch Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/coreclr/tools/superpmi/superpmi/jithost.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,12 +114,13 @@ bool JitHost::convertStringValueToInt(const char* key, const char* stringValue,
return false;
}

char* endPtr;
char* endPtr;
errno = 0;
unsigned long longResult = strtoul(stringValue, &endPtr, 16);
Comment thread
jakobbotsch marked this conversation as resolved.
bool succeeded = (errno != ERANGE) && (endPtr != stringValue) && (longResult <= INT_MAX);
bool succeeded = (errno != ERANGE) && (endPtr != stringValue) && (longResult <= UINT_MAX);
if (!succeeded)
{
LogWarning("Can't convert int config value from string, key: %ws, string value: %ws\n", key, stringValue);
LogWarning("Can't convert int config value from string, key: %s, string value: %s\n", key, stringValue);
Comment thread
jakobbotsch marked this conversation as resolved.
return false;
}

Expand Down
Loading