Skip to content

Guard stackwalking in IXClrDataStackWalk codepaths to account for underlying max size of context #125819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hoyosjs merged 1 commit into from
Apr 10, 2026
Merged

Guard stackwalking in IXClrDataStackWalk codepaths to account for underlying max size of context #125819

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/coreclr/debug/daccess/stack.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ ClrDataStackWalk::GetContext(
{
T_CONTEXT tmpContext = m_context;
UpdateContextFromRegDisp(&m_regDisp, &tmpContext);
CopyMemory(contextBuf, &tmpContext, contextBufSize);
CopyMemory(contextBuf, &tmpContext, min(contextBufSize, (ULONG32)sizeof(tmpContext)));
status = S_OK;
}
}
Expand Down Expand Up @@ -157,7 +157,7 @@ ClrDataStackWalk::SetContext2(
{
// Copy the context to local state so
// that its lifetime extends beyond this call.
CopyMemory(&m_context, context, contextSize);
CopyMemory(&m_context, context, min(contextSize, (ULONG32)sizeof(m_context)));
m_thread->FillRegDisplay(&m_regDisp, &m_context);
m_frameIter.ResetRegDisp(&m_regDisp, (flags & CLRDATA_STACK_SET_CURRENT_CONTEXT) != 0);
m_stackPrev = (TADDR)GetRegdisplaySP(&m_regDisp);
Expand Down Expand Up @@ -663,7 +663,7 @@ ClrDataFrame::GetContext(

EX_TRY
{
CopyMemory(contextBuf, &m_context, contextBufSize);
CopyMemory(contextBuf, &m_context, min(contextBufSize, (ULONG32)sizeof(m_context)));
status = S_OK;
}
EX_CATCH
Expand Down
Loading