Skip to content

Fix perfmap output #122273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tommcdon merged 3 commits into from
Dec 8, 2025
Merged

Fix perfmap output #122273

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c93c88a
Fix perfmap output
tommcdon Dec 7, 2025
d18f1ca
Use fprintf as it is more performant than write for perfmaps
tommcdon Dec 8, 2025
f5a49ad
Avoid potential inadvertant conversation to unicode with SString.GetC…
tommcdon Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions src/coreclr/vm/perfmap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,14 +261,12 @@ void PerfMap::WriteLine(SString& line)
EX_TRY
{
// Write the line.

if (fprintf(m_fp, "%s", line.GetUTF8()) != 0)
Comment thread
tommcdon marked this conversation as resolved.
if (fprintf(m_fp, "%s", line.GetUTF8()) < 0)
{
// This will cause us to stop writing to the file.
// The file will still remain open until shutdown so that we don't have to take a lock at this level when we touch the file stream.
m_ErrorEncountered = true;
}

}
EX_CATCH{} EX_END_CATCH
}
Expand Down