Skip to content

properly enumerate uninstrumented bounds#119965

Merged
max-charlamb merged 4 commits into
dotnet:mainfrom
max-charlamb:119921-fix
Sep 24, 2025
Merged

properly enumerate uninstrumented bounds#119965
max-charlamb merged 4 commits into
dotnet:mainfrom
max-charlamb:119921-fix

Conversation

@max-charlamb

@max-charlamb max-charlamb commented Sep 22, 2025

Copy link
Copy Markdown
Member

partial fix for #119921.

@github-actions github-actions Bot added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Sep 22, 2025
@max-charlamb max-charlamb added area-Diagnostics-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Sep 22, 2025
@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag
See info in area-owners.md if you want to be subscribed.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the enumeration of memory regions for debug information by properly handling uninstrumented bounds that were introduced in a previous change. The fix ensures that both instrumented and uninstrumented bounds are correctly accounted for when enumerating memory regions, and adds proper alignment padding to prevent partial read failures.

Key Changes:

  • Updates memory region enumeration to handle uninstrumented bounds alongside existing instrumented bounds
  • Adds alignment padding to prevent NibbleReader from partially failing on unaligned debug info streams

Comment thread src/coreclr/vm/debuginfostore.cpp

@noahfalk noahfalk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@max-charlamb max-charlamb merged commit c99d384 into dotnet:main Sep 24, 2025
99 checks passed
@max-charlamb max-charlamb deleted the 119921-fix branch September 24, 2025 19:23
@steveisok

Copy link
Copy Markdown
Member

/backport to release/10.0

@github-actions

Copy link
Copy Markdown
Contributor

Started backporting to release/10.0: https://github.com/dotnet/runtime/actions/runs/17990332541

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants