Skip to content

Fix metric tests timeout issue#117630

Merged
tarekgh merged 5 commits into
dotnet:mainfrom
tarekgh:FixMetricTests
Jul 16, 2025
Merged

Fix metric tests timeout issue#117630
tarekgh merged 5 commits into
dotnet:mainfrom
tarekgh:FixMetricTests

Conversation

@tarekgh

@tarekgh tarekgh commented Jul 14, 2025

Copy link
Copy Markdown
Member

Fixes #117226

Copilot AI review requested due to automatic review settings July 14, 2025 22:38
@tarekgh

tarekgh commented Jul 14, 2025

Copy link
Copy Markdown
Member Author

/azp list

@azure-pipelines

Copy link
Copy Markdown
CI/CD Pipelines for this repository:

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR increases the timeout for all remote-invoked metric tests to address intermittent CI timeouts.

  • Adds a shared RemoteInvokeOptions instance with an extended timeout
  • Updates each RemoteInvoke(...).Dispose() call to pass the new timeout options

Comment thread src/libraries/System.Diagnostics.DiagnosticSource/tests/MetricsTests.cs Outdated
…sTests.cs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@tarekgh

tarekgh commented Jul 14, 2025

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@tarekgh

tarekgh commented Jul 14, 2025

Copy link
Copy Markdown
Member Author

/azp run runtime-coreclr jitstress

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@tarekgh tarekgh added this to the 10.0.0 milestone Jul 14, 2025
@tarekgh tarekgh requested review from ericstj and noahfalk July 14, 2025 22:41
@tarekgh tarekgh merged commit 1687ae3 into dotnet:main Jul 16, 2025
83 of 87 checks passed
@github-actions github-actions Bot locked and limited conversation to collaborators Aug 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure: System.Diagnostics.Metrics.Tests.MetricsTests.ThrowingExceptionsFromObservableInstrumentCallbacks

3 participants