Disable WER for host test apps that intentionally crash#116936
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR disables Windows error reporting for host test applications that intentionally crash by calling SetErrorMode with the NOGPFAULTERRORBOX flag.
- Disables core dumps for specific Windows tests
- Adds Windows-specific error mode handling in CoreDump.cs
Comments suppressed due to low confidence (1)
src/installer/tests/Assets/Projects/CoreDump.cs:37
- [nitpick] Consider adding a brief inline comment explaining why SetErrorMode is called with NOGPFAULTERRORBOX on Windows to improve maintainability and clarify intent for future reviewers.
else if (OperatingSystem.IsWindows())
Contributor
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
hoyosjs
approved these changes
Jun 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Call
SetErrorModewithNOGPFAULTERRORBOXper @MichalStrehovsky's suggestion in #116725 (comment)This disables dumps for the tests that intentionally crash when we are crashing from the app. For something like
Muxer_NonAssemblyWithExeExtensionwhere there is no test-specific code running, we don't have anywhere to hook in to do this, so that still ends up with a dump. But this change at least gets rid of the other ones.cc @dotnet/appmodel @AaronRobinsonMSFT