Revert "Disable Shake Read tests on AzureLinux"#115517
Merged
Merged
Conversation
This reverts commit 3aaffd0.
Contributor
|
Tagging subscribers to this area: @dotnet/area-system-security, @bartonjs, @vcsjones |
Contributor
There was a problem hiding this comment.
Pull Request Overview
Restores SHAKE squeeze unit tests on Azure Linux now that SymCrypt-OpenSSL 1.8 adds read support by removing the Azure Linux exclusion.
- Re-enable
IsReadSupportedcheck for Azure Linux - Remove the
ActiveIssueskip on theRead_NotSupportedtest
Comments suppressed due to low confidence (1)
src/libraries/System.Security.Cryptography/tests/ShakeTestDriver.cs:747
- The
Read_NotSupportedtest is now running on Azure Linux (where Read is supported). It should only execute when Read is not supported. Consider adding a newIsReadNotSupportedproperty (e.g.public static bool IsReadNotSupported => IsSupported && !IsReadSupported;) and using[ConditionalFact(nameof(IsReadNotSupported))].
[ConditionalFact(nameof(IsSupported))]
bartonjs
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request restores the unit tests for squeeze functionality for SHAKE on Azure Linux. This is fixed as of SymCrypt-OpenSSL 1.8.
Reverts #112037
Fixes #112036