[WinHTTP] Fix certificate caching timeout#115144
Merged
liveans merged 2 commits intodotnet:mainfrom Apr 30, 2025
Merged
Conversation
ghost
added
the
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to fix the certificate caching timeout in the WinHttpHandler by updating the calculation for s_staleTimeout.
- Updated the computation of s_staleTimeout by removing an unnecessary division by 1000.
- Ensured consistency between the timeout interval in seconds and the value calculated in Stopwatch ticks.
src/libraries/System.Net.Http.WinHttpHandler/src/System/Net/Http/WinHttpHandler.cs
Show resolved
Hide resolved
Contributor
|
Tagging subscribers to this area: @dotnet/ncl |
MihaZupan
approved these changes
Apr 29, 2025
This was referenced Apr 29, 2025
Member
Author
|
/azp run runtime-libraries-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
3 tasks
Member
Author
|
/ba-g failures unrelated (Interop JS) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#114678 (comment)