[wasm][interp] Filter out overmatched shift#114492
Merged
Merged
Conversation
ghost
added
the
lewing
requested review from
BrzVlad,
kotlarmilos,
steveisok and
vitek-karas
as code owners
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/mono/mono/mini/interp/transform-simd.c:1089
- Ensure that unit tests cover both the HOST_BROWSER and non-HOST_BROWSER branches to verify the correct behavior of the SN_get_IsSupported/IsHardwareAccelerated handling.
#if HOST_BROWSER
Contributor
|
Tagging subscribers to this area: @BrzVlad, @kotlarmilos |
javiercn
approved these changes
Apr 10, 2025
Member
Author
|
/ba-g timeouts passed pertinent tests before timing out and are unrelated |
This was referenced Apr 10, 2025
Open
12 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix for https://github.com/dotnet/AspNetCore-ManualTests/issues/3559