Skip to content

Fix issue where wrong message was added to EventReporter.#113969

Merged
akoeplinger merged 1 commit into
dotnet:mainfrom
lateralusX:lateralusX/fix-event-logging
Mar 27, 2025
Merged

Fix issue where wrong message was added to EventReporter.#113969
akoeplinger merged 1 commit into
dotnet:mainfrom
lateralusX:lateralusX/fix-event-logging

Conversation

@lateralusX

@lateralusX lateralusX commented Mar 27, 2025

Copy link
Copy Markdown
Member

#113416 used a shared SString buffer when building the log message written to console when hitting an unhandled managed exception. It appears that the same buffer was used when passing data over to EventReporter, but it would then include more information than expected. This will fix so we only pass over the exception message, inline with previous beharior.

Fixes issue found in dotnet/aspnetcore#61011.

Copilot AI review requested due to automatic review settings March 27, 2025 15:16

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/coreclr/vm/excep.cpp: Language not supported

@akoeplinger

Copy link
Copy Markdown
Member

/ba-g failure is unrelated

@akoeplinger akoeplinger merged commit fa004fb into dotnet:main Mar 27, 2025
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-ExceptionHandling-coreclr only use for closed issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants