Fix targets for using the NativeAOT runtime pack as the "target ILC" pack#113902
Merged
jkoritzinsky merged 2 commits intoMar 27, 2025
Merged
Conversation
…ut but not actually using it as a runtime pack. The NAOT assemblies won't be there.
ghost
added
the
Contributor
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas |
This was referenced Mar 26, 2025
Open
sbomer
approved these changes
Mar 26, 2025
sbomer
left a comment
sbomer
left a comment
Member
There was a problem hiding this comment.
LGTM once you fixglobbing for _NETCoreAppRuntimePackPath as discussed. Thanks!
Member
Author
|
/ba-g failures unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change how we select the assets as we aren't using this package as a runtime pack.
Unblocks dotnet/sdk#46611