Skip to content

Revert "Revert "Revert "Pin SHAs for container images"""#113659

Merged
jkotas merged 1 commit into
mainfrom
revert-113598-revert-113248-revert-113185-shaken
Mar 19, 2025
Merged

Revert "Revert "Revert "Pin SHAs for container images"""#113659
jkotas merged 1 commit into
mainfrom
revert-113598-revert-113248-revert-113185-shaken

Conversation

@richlander

Copy link
Copy Markdown
Member

Relies on testing:

  • runtime-libraries-coreclr
  • runtime-nativeaot-outerloop
  • outerloop-linux

Copilot AI review requested due to automatic review settings March 18, 2025 17:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts previous changes that pinned container image SHAs to enable the upgrade to clang 20. The key changes include removing SHA-based version locking for various container images used in the pipeline, restoring them to tag-based references, and aligning with the upstream changes in related .NET runtime repositories.

Comments suppressed due to low confidence (1)

eng/pipelines/common/templates/pipeline-with-resources.yml:20

  • Removing the SHA pin may lead to non-deterministic builds if the upstream container image is updated unexpectedly. Consider verifying that using the tag-only reference will not adversely affect stability.
        image: mcr.microsoft.com/dotnet-buildtools/prereqs:azurelinux-3.0-net10.0-cross-arm

@richlander

Copy link
Copy Markdown
Member Author

/azp run runtime-libraries-coreclr runtime-nativeaot-outerloop outerloop-linux

@azure-pipelines

Copy link
Copy Markdown
No pipelines are associated with this pull request.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@richlander

Copy link
Copy Markdown
Member Author

This all looks unrelated. Look OK @sbomer?

@jkotas

jkotas commented Mar 19, 2025

Copy link
Copy Markdown
Member

No pipelines are associated with this pull request.

I think this means that azdo rejected the command and it did not run the extra legs. I do not see any NativeAOT Arm32 runs that got the previous attempt reverted.

@jkotas

jkotas commented Mar 19, 2025

Copy link
Copy Markdown
Member

/azp run runtime-nativeaot-outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

jkotas commented Mar 19, 2025

Copy link
Copy Markdown
Member

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jkotas

jkotas commented Mar 19, 2025

Copy link
Copy Markdown
Member

/azp run runtime-libraries-coreclr outerloop-linux

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@richlander

Copy link
Copy Markdown
Member Author

Thanks. I looked at the pipelines that were run and I wondered if those were missed. Thanks for kicking them off for real.

@jkotas jkotas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

None of the failures look related

@jkotas

jkotas commented Mar 19, 2025

Copy link
Copy Markdown
Member

/ba-g unrelated timeouts

@jkotas

jkotas commented Mar 19, 2025

Copy link
Copy Markdown
Member

Also, the SDK non-deterministic crash that we suspect is related to clang 20 did not go away with the revert dotnet/sdk#47580 (comment) so it is unrelated.

@jkotas jkotas merged commit 5ab9dfe into main Mar 19, 2025
@jkotas jkotas deleted the revert-113598-revert-113248-revert-113185-shaken branch March 19, 2025 15:13
@github-actions github-actions Bot locked and limited conversation to collaborators Apr 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants