[Apple mobile] Run System.Runtime.Serialization.Xml.ExporterTypesTests.TypesTest when DataSetXmlSerializationIsSupported is set#113084
Merged
Conversation
kotlarmilos
added
NO-MERGE
Member
Author
|
/azp run runtime-ioslike |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
another option would be to exclude the trimmed type from testing when PlatformDetection.DataSetXmlSerializationIsSupported is true |
This was referenced Mar 3, 2025
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adjusts test configuration for Apple mobile by enabling DataSetXmlSerialization support in the XML serialization tests.
- Replaces [Fact] with [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.DataSetXmlSerializationIsSupported))] to conditionally run tests based on platform capabilities.
kotlarmilos
changed the title
DataSetXmlSerializationSupport to true in System.Runtime.Serialization.Xml.TestsSystem.Runtime.Serialization.Xml.ExporterTypesTests.TypesTest when DataSetXmlSerializationIsSupported is set
kotlarmilos
removed
NO-MERGE
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
akoeplinger
approved these changes
Mar 13, 2025
This was referenced Mar 13, 2025
Member
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/ba-g wasm timeouts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #113062