Skip to content

[cDAC] Implement core stackwalking#111759

Merged
max-charlamb merged 56 commits into
dotnet:mainfrom
max-charlamb:cdac-stackwalk
Feb 27, 2025
Merged

[cDAC] Implement core stackwalking#111759
max-charlamb merged 56 commits into
dotnet:mainfrom
max-charlamb:cdac-stackwalk

Conversation

@max-charlamb

@max-charlamb max-charlamb commented Jan 23, 2025

Copy link
Copy Markdown
Member

Contributes to #110758

Implements bulk of the cDAC stackwalking mechanics.

  • IStackWalk contract

Supports amd64 and arm64 architectures. Tested on Windows targeting win-amd64 and linux-arm64 dumps.

Supports InlineCallFrames and SoftwareExceptionFrames.

Does not support and will be added in future PRs:

@max-charlamb max-charlamb marked this pull request as ready for review February 6, 2025 23:22
Comment thread src/coreclr/unwinder/amd64/unwinder.cpp Outdated
@max-charlamb max-charlamb changed the title [cDAC] Stackwalking [cDAC] Implement basic stackwalking Feb 6, 2025
Comment thread docs/design/datacontracts/ExecutionManager.md Outdated

@davidwrighton davidwrighton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@max-charlamb max-charlamb changed the title [cDAC] Implement basic stackwalking [cDAC] Implement core stackwalking Feb 26, 2025

@lateralusX lateralusX left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants