JIT: handle nested try case in empty try removal#111129
Merged
Merged
Conversation
When we remove a try region, the try entry block may still be a try entry for enclosing try regions, so we can't unconditionally drop the DONT_REMOVE flag. Fixes dotnet#110958
ghost
added
the
area-CodeGen-coreclr
Member
Author
|
@amanasifkhalid PTAL |
amanasifkhalid
approved these changes
Jan 6, 2025
Contributor
|
fwiw, #82336 |
Member
Author
What I was hoping to get to someday was to have all block references be enumerable from the block -- most would be from flow edges like with our current pred lists, but we'd have some special references from the EH table, statics on the compiler object (eg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we remove a try region, the try entry block may still be a try entry for enclosing try regions, so we can't unconditionally drop the DONT_REMOVE flag.
Fixes #110958