[browser] fix 4GB JS interop - #109079
Merged
Merged
[browser] fix 4GB JS interop#109079
Conversation
pavelsavara
added
arch-wasm
This was referenced Oct 21, 2024
pavelsavara
marked this pull request as ready for review
October 24, 2024 17:17
pavelsavara
requested review from
ilonatommy,
lewing and
maraf
as code owners
October 24, 2024 17:17
pavelsavara
requested review from
ilonatommy,
kg and
maraf
and removed request for
ilonatommy,
lewing and
maraf
October 24, 2024 17:17
kg
reviewed
Oct 24, 2024
kg
reviewed
Oct 24, 2024
kg
approved these changes
Oct 24, 2024
kg
left a comment
kg
left a comment
Contributor
There was a problem hiding this comment.
I like the incremental improvements you're making while doing this
ilonatommy
reviewed
Oct 25, 2024
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
Co-authored-by: Ilona Tomkowicz <32700855+ilonatommy@users.noreply.github.com>
This was referenced Oct 25, 2024
maraf
reviewed
Oct 31, 2024
Co-authored-by: Marek Fišera <mara@neptuo.com>
This was referenced Oct 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is
use on your own riskEven when we try to make this work, we do not think it's good idea to allocate more than 256MB in a web page.
mallocwhich is wrapper overModule._mallocthat returnsuint32rather than negative number above 2GBIntPtrasuint32to JS, because typically it's used as offset to arrayModuleparameter topreRunand other emscripten events. So that it could be used to test memory.MemoryTestWBT to waste 2GB before starting the mono runtime.