[cdac] Fix getting free object size in GetObjectData#106505
Merged
Merged
Conversation
elinor-fung
requested review from
AaronRobinsonMSFT,
davidwrighton and
lambdageek
Contributor
|
Tagging subscribers to this area: @tommcdon |
davidwrighton
approved these changes
Aug 15, 2024
AaronRobinsonMSFT
approved these changes
Aug 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missed that free objects also have their component count set - explicitly at the array base offset for num components. This updates the cDAC implementation of
ISOSDacInterface::GetObjectDatato correctly handle free objects with a non-zero component count.