Fix the flakiness of new BinaryFormatter tests#103476

Merged

adamsitnik merged 6 commits into

dotnet:mainfrom

adamsitnik:flakyBfTests

Jun 17, 2024

Commits on Jun 14, 2024

reproduce the problem by calling EqualityExtensions.CheckEquals up-front as it enumerates all properties and may change the contents of the fields
adamsitnik
committed
change the test class Equals method implementation and allow the branches to be the same object, as we want to compare exactly the same object on purpose
adamsitnik
committed
change the affected blob to represent all fields, including lazy-evaluated SortedList<TKey, TValue>.keyList and valueList
adamsitnik
committed
do not cache the test input data, as some tests may by accident mutate it which may cause hard to repro failures based on the order of executed tests
adamsitnik
committed
remove the check I've added recently but was not present in the original BF tests
adamsitnik
committed
add a call to EqualityExtensions.CheckEquals for all the tests that use it
adamsitnik
committed