[Mono] OptionsMonitorTest.TestCurrentValueDoesNotAllocateOnceValueIsCached Test Fails

[steveisok]

Found in the rolling build and the test fails with:

runtime/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs

Lines 473 to 485 in 670262a

	[Fact]
	public void TestCurrentValueDoesNotAllocateOnceValueIsCached()
	{
	var monitor = new OptionsMonitor<FakeOptions>(
	new OptionsFactory<FakeOptions>(Enumerable.Empty<IConfigureOptions<FakeOptions>>(), Enumerable.Empty<IPostConfigureOptions<FakeOptions>>()),
	Enumerable.Empty<IOptionsChangeTokenSource<FakeOptions>>(),
	new OptionsCache<FakeOptions>());
	Assert.NotNull(monitor.CurrentValue); // populate the cache
	long initialBytes = GC.GetAllocatedBytesForCurrentThread();
	_ = monitor.CurrentValue;
	Assert.Equal(0, GC.GetAllocatedBytesForCurrentThread() - initialBytes);
	}

Assert.Equal() Failure
Expected: 0
Actual:   24

Tagging subscribers to 'os-ios': @steveisok, @akoeplinger
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Found in the rolling build and the test fails with:

runtime/src/libraries/Microsoft.Extensions.Options/tests/Microsoft.Extensions.Options.Tests/OptionsMonitorTest.cs

Lines 473 to 485 in 670262a

	[Fact]
	public void TestCurrentValueDoesNotAllocateOnceValueIsCached()
	{
	var monitor = new OptionsMonitor<FakeOptions>(
	new OptionsFactory<FakeOptions>(Enumerable.Empty<IConfigureOptions<FakeOptions>>(), Enumerable.Empty<IPostConfigureOptions<FakeOptions>>()),
	Enumerable.Empty<IOptionsChangeTokenSource<FakeOptions>>(),
	new OptionsCache<FakeOptions>());
	Assert.NotNull(monitor.CurrentValue); // populate the cache
	long initialBytes = GC.GetAllocatedBytesForCurrentThread();
	_ = monitor.CurrentValue;
	Assert.Equal(0, GC.GetAllocatedBytesForCurrentThread() - initialBytes);
	}

Assert.Equal() Failure
Expected: 0
Actual:   24

Author:	steveisok
Assignees:	-
Labels:	os-ios, os-tvos
Milestone:	Future

[carlossanlop]

Found again in this runtime-extra-platforms rolling build from today:https://dev.azure.com/dnceng/public/_build/results?buildId=1700096&view=results

Artifacts: https://dev.azure.com/dnceng/public/_build/results?buildId=1700096&view=ms.vss-test-web.build-test-results-tab&runId=46336764&resultId=134879&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab

Log file: net.dot.Microsoft.Extensions.Options.Tests.log

Callstack:

[03:17:20.4929170] 2022-04-05 03:17:20.453 Microsoft.Extensions.Options.Tests[52859:67860912] Failed tests:
[03:17:20.4961440] 2022-04-05 03:17:20.456 Microsoft.Extensions.Options.Tests[52859:67860912] 1) 	[FAIL] Microsoft.Extensions.Options.Tests.OptionsMonitorTest.TestCurrentValueDoesNotAllocateOnceValueIsCached   Test name: Microsoft.Extensions.Options.Tests.OptionsMonitorTest.TestCurrentValueDoesNotAllocateOnceValueIsCached
[03:17:20.4961780] 2022-04-05 03:17:20.456 Microsoft.Extensions.Options.Tests[52859:67860912]    Assembly:  [Microsoft.Extensions.Options.Tests, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]
[03:17:20.4961970]    Exception messages: Assert.Equal() Failure
[03:17:20.4962010] Expected: 0
[03:17:20.4962080] 2022-04-05 03:17:20.456 Microsoft.Extensions.Options.Tests[52859:67860912] Actual:   24   Exception stack traces:    at Microsoft.Extensions.Options.Tests.OptionsMonitorTest.TestCurrentValueDoesNotAllocateOnceValueIsCached()
[03:17:20.4962130]    at System.Reflection.RuntimeMethodInfo.InvokeWorker(Object obj, BindingFlags invokeAttr, Span`1 parameters)
[03:17:20.4962170]    Execution time: 0.0105616

[carlossanlop]

Ah, sorry. Just noticed this is reporting the same rolling build failure, and you merged a fix. Removing the blocking label.

[carlossanlop]

I saw this again in runtime-extra-platforms but I suspect it's because the fix above was not included yet in this rolling build from early morning:

• Pipeline: Build tvOS arm64 Release AllSubsets_Mono
  Job: https://dev.azure.com/dnceng/public/_build/results?buildId=1701191&view=logs&j=f4520fb1-1559-5885-1d9c-3cb3f6a85e23&t=6c7a8cfe-f92e-569a-eef9-b2ad3e13056d&l=65
  Artifacts: https://dev.azure.com/dnceng/public/_build/results?buildId=1701191&view=ms.vss-test-web.build-test-results-tab&runId=46369408&resultId=131420&paneView=dotnet-dnceng.dnceng-build-release-tasks.helix-test-information-tab
  Test method: Microsoft.Extensions.Options.Tests.OptionsMonitorTest.TestCurrentValueDoesNotAllocateOnceValueIsCached
  Callstack:

Test name: Microsoft.Extensions.Options.Tests.OptionsMonitorTest.TestCurrentValueDoesNotAllocateOnceValueIsCached
[15:20:18.3110440] 2022-04-05 15:20:18.368 Microsoft.Extensions.Options.Tests[38963:48017886]    Assembly:  [Microsoft.Extensions.Options.Tests, Version=7.0.0.0, Culture=neutral, PublicKeyToken=adb9793829ddae60]
[15:20:18.3110500]    Exception messages: Assert.Equal() Failure
[15:20:18.3110540] Expected: 0
[15:20:18.3115400] 2022-04-05 15:20:18.369 Microsoft.Extensions.Options.Tests[38963:48017886] Actual:   24   Exception stack traces:    at Microsoft.Extensions.Options.Tests.OptionsMonitorTest.TestCurrentValueDoesNotAllocateOnceValueIsCached()
[15:20:18.3115630]    at System.Reflection.RuntimeMethodInfo.InvokeWorker(Object obj, BindingFlags invokeAttr, Span`1 parameters)
[15:20:18.3115690]    Execution time: 0.0114359