[Perf] Regression in deps.json Size for Blazor Pizza App

[DrewScoggins]

Run Information

Architecture	x64
OS	ubuntu 18.04
Baseline Commit	c0d51224117c932288bc5eadbd3493fed10bc299
Baseline Publish	Baseline
Compare Commit	ac82799250fe42c8ba2941aef487aca94ecf04cc
Compare Publish	Compare
Diff	Diff

Regressions in SOD - Pizza App - Publish

Benchmark	Baseline	Test	Test/Base	Test Quality	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
SOD - Pizza App - Publish - pub/BlazingPizza.ComponentsLibrary.deps.json	61.65 KB	62.39 KB	1.01	0.00
SOD - Pizza App - Publish - Aggregate - .json	138.66 KB	140.14 KB	1.01	0.00
SOD - Pizza App - Publish - pub/BlazingPizza.ComponentsLibrary.pdb	12.32 KB	12.44 KB	1.01	0.00
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Net.Primitives.dll.br	2.58 KB	2.63 KB	1.02	0.00
SOD - Pizza App - Publish - pub/BlazingComponents.deps.json	61.60 KB	62.34 KB	1.01	0.00
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Net.Http.Json.dll.br	5.90 KB	5.97 KB	1.01	0.00
SOD - Pizza App - Publish - pub/wwwroot/_framework/dotnet.timezones.blat.gz	70.18 KB	72.20 KB	1.03	0.00

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - Pizza App - Publish*'

Details

Histogram

SOD - Pizza App - Publish

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Tagging subscribers to 'size-reduction': @eerhardt, @SamMonoRT, @marek-safar, @CoffeeFlux
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Run Information

Architecture	x64
OS	ubuntu 18.04
Baseline Commit	c0d51224117c932288bc5eadbd3493fed10bc299
Baseline Publish	Baseline
Compare Commit	ac82799250fe42c8ba2941aef487aca94ecf04cc
Compare Publish	Compare
Diff	Diff

Regressions in SOD - Pizza App - Publish

Benchmark	Baseline	Test	Test/Base	Test Quality	Baseline IR	Compare IR	IR Ratio	Baseline ETL	Compare ETL
SOD - Pizza App - Publish - pub/BlazingPizza.ComponentsLibrary.deps.json	61.65 KB	62.39 KB	1.01	0.00
SOD - Pizza App - Publish - Aggregate - .json	138.66 KB	140.14 KB	1.01	0.00
SOD - Pizza App - Publish - pub/BlazingPizza.ComponentsLibrary.pdb	12.32 KB	12.44 KB	1.01	0.00
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Net.Primitives.dll.br	2.58 KB	2.63 KB	1.02	0.00
SOD - Pizza App - Publish - pub/BlazingComponents.deps.json	61.60 KB	62.34 KB	1.01	0.00
SOD - Pizza App - Publish - pub/wwwroot/_framework/System.Net.Http.Json.dll.br	5.90 KB	5.97 KB	1.01	0.00
SOD - Pizza App - Publish - pub/wwwroot/_framework/dotnet.timezones.blat.gz	70.18 KB	72.20 KB	1.03	0.00

Historical Data in Reporting System

Repro

git clone https://github.com/dotnet/performance.git
python3 .\performance\scripts\benchmarks_ci.py -f netcoreapp5.0 --filter 'SOD - Pizza App - Publish*'

Details

Histogram

SOD - Pizza App - Publish

Docs

Profiling workflow for dotnet/runtime repository
Benchmarking workflow for dotnet/runtime repository

Author:	DrewScoggins
Assignees:	-
Labels:	size-reduction, tenet-performance-benchmarks
Milestone:	-

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[eerhardt]

A couple of notes:

1. I don't think the .deps.json files are actually part of the "published" output of a Blazor WASM app. So I'm not sure measuring their sizes is beneficial.
2. The changes in the .deps.json file include these entries:
   
   Which I believe are caused from Dead end S.Security.Cryptography.OpenSsl package #51854 and Dead end S.Security.Cryptography.Cng package #51853. cc @ViktorHofer

[DrewScoggins]

I see. I will change these tests to just measure the size in the wwwroot directory, as that seems like the place where we actually publish the WASM app.

[ViktorHofer]

Which I believe are caused from #51854 and #51853. cc @ViktorHofer

Is there an issue with these changes?

[eerhardt]

Is there an issue with these changes?

I'm not sure. Are they expected to be in the .deps.json files when they weren't before?

[ViktorHofer]

I'm not sure. Are they expected to be in the .deps.json files when they weren't before?

How should I interpret the diff? Is the right hand side (the removal) with my changes or without? I don't know about which app's deps.json we are talking about? How are Cng and OpenSsl in that app referenced?

The removal of these packages by the SDK makes perfect sense as those are now inbox and also part of the targeting pack.

[eerhardt]

How should I interpret the diff?

The left side is the "baseline", the right side is "after". The deps.json file got larger after the change, since the entries were added to it.

as those are now inbox and also part of the targeting pack.

Ok, then that explains why they are showing up. So it is expected then if they got moved inbox.

[ViktorHofer]

Ok, then that explains why they are showing up. So it is expected then if they got moved inbox.

Yes, I believe moving them inbox results in them showing up in the deps.json.

[eerhardt]

Closing. See above reasoning:

1. We shouldn't be tracking deps.json file sizes because they are not part of the published Blazor WASM app.
2. These changes are expected.