System.Data.Common.DbProviderFactoriesTests failing in CI

[jaredpar]

A number of tests are failing, using GetFactoryWithDataRowTest as the marker test to follow. The first build to demonstrate this was 509362

System.Data.Common.DbProviderFactoriesTests.GetFactoryWithDataRowTest

Console Log Summary

Appears to be a simple test failure

    System.Data.Common.DbProviderFactoriesTests.RegisterFactoryWithTypeNameTest [FAIL]
      System.InvalidOperationException : The requested .NET Data Provider's implementation does not have an Instance field of a System.Data.Common.DbProviderFactory derived type.
      Stack Trace:
        /_/src/libraries/System.Data.Common/src/System/Data/Common/DbProviderFactories.cs(184,0): at System.Data.Common.DbProviderFactories.GetFactoryInstance(Type providerFactoryClass)
        /_/src/libraries/System.Data.Common/src/System/Data/Common/DbProviderFactories.cs(69,0): at System.Data.Common.DbProviderFactories.GetFactory(DataRow providerRow)
        /_/src/libraries/System.Data.Common/tests/System/Data/Common/DbProviderFactoriesTests.cs(199,0): at System.Data.Common.DbProviderFactoriesTests.RegisterSqlClientAndTestRegistration(Action registrationFunc)
        /_/src/libraries/System.Data.Common/tests/System/Data/Common/DbProviderFactoriesTests.cs(72,0): at System.Data.Common.DbProviderFactoriesTests.RegisterFactoryWithTypeNameTest()
      System.ArgumentNullException : Value cannot be null. (Parameter 'factory')
      Stack Trace:

Builds

Build	Pull Request	Test Failure Count
#508988	Rolling	1
#509362	Rolling	1
#509595	Rolling	1
#509747	Rolling	1
#509802	Rolling	1
#509865	Rolling	1
#509985	Rolling	1

Configurations

• netcoreapp5.0-Linux-Release-arm64-CoreCLR_release-(Alpine.38.Arm64.Open)Ubuntu.1804.ArmArch.Open@mcr.microsoft.com/dotnet-buildtools/prereqs:alpine-3.8-helix-arm64v8-a45aeeb-20190620184035

Helix Logs

Build	Pull Request	Console	Core	Test Results
#508988	Rolling	console.fc1893ef.log
#509362	Rolling	console.62f42be5.log
#509595	Rolling	console.29bc91e3.log
#509747	Rolling	console.c8ef635c.log
#509802	Rolling	console.c09790cc.log
#509865	Rolling	console.33be4e10.log
#509985	Rolling	console.b1b2ed3b.log

[jaredpar]

@danmosemsft who owns the DbProviderFactoriesTests suite? It's failing 100% on ARM64 right now.

[ViktorHofer]

Fixed with 4b4d741.

[jaredpar]

#31850

[ViktorHofer]

A commits links to its PR :)

[jaredpar]

@ViktorHofer correct. But specifying the commit SHA won't cause the PR to link back to the issue. Linking to the PR means it will in turn link to the issue. That way when you look at the PR you can see the issues that are relevant to the changes.

[ViktorHofer]

That makes perfect sense, thanks for letting me know :)