Skip to content

Add Unicode 13.0 UCD assets#66

Merged
ViktorHofer merged 1 commit into
dotnet:masterfrom
GrabYourPitchforks:unicodedata
Mar 12, 2020
Merged

Add Unicode 13.0 UCD assets#66
ViktorHofer merged 1 commit into
dotnet:masterfrom
GrabYourPitchforks:unicodedata

Conversation

@GrabYourPitchforks

Copy link
Copy Markdown
Member

This is the runtime-assets portion of dotnet/runtime#2378. Once the assets package is updated, we can ingest it within the runtime + libraries.

This PR contains select files copied from https://www.unicode.org/Public/13.0.0/.

I've also updated the third-party licenses file to point to their new license URL. The text is copied from https://www.unicode.org/license.html, everything after the heading "COPYRIGHT AND PERMISSION NOTICE". In practice the only things they updated were the URL and the copyright year.

Viktor, is there anything I need to do with regard to the package versions? I assume once the PR is merged the build system will automatically spit out new packages with an updated version number?

@GrabYourPitchforks GrabYourPitchforks added this to the 5.0 milestone Mar 11, 2020
@GrabYourPitchforks

Copy link
Copy Markdown
Member Author

Note: the directory structure is a little different for the 13.0 assets. Instead of the directory structure emoji/{major}.{minor}, the emoji data files were moved under {major}.{minor}.{revision}/ucd/emoji. Not sure why Unicode did this, but whatever. :) I'll account for it at runtime ingestion time.

@ViktorHofer ViktorHofer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No additional action needed in regards to version. Everything flows automatically now :)

@ViktorHofer ViktorHofer merged commit 9f99c47 into dotnet:master Mar 12, 2020
@GrabYourPitchforks GrabYourPitchforks deleted the unicodedata branch March 12, 2020 15:17
@GrabYourPitchforks

GrabYourPitchforks commented Mar 12, 2020

Copy link
Copy Markdown
Member Author

Tracking: The PR dotnet/runtime#33562 carries the assets payload for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants