Skip to content

Fix analyzer RCS1231 (#1769) - #1774

Merged
josefpihrt merged 5 commits into
dotnet:mainfrom
cbersch:fix-rcs1231
Aug 2, 2026
Merged

Fix analyzer RCS1231 (#1769)#1774
josefpihrt merged 5 commits into
dotnet:mainfrom
cbersch:fix-rcs1231

Conversation

@cbersch

@cbersch cbersch commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Fix #1769

@cbersch
cbersch marked this pull request as ready for review June 19, 2026 13:17
Comment thread ChangeLog.md Outdated
Comment thread src/Tests/Analyzers.Tests/RCS1231MakeParameterRefReadOnlyTests.cs Outdated
@cbersch
cbersch requested a review from josefpihrt August 2, 2026 10:35
@josefpihrt
josefpihrt merged commit 6235908 into dotnet:main Aug 2, 2026
17 checks passed
This was referenced Aug 8, 2026
renebentes pushed a commit to renebentes/3054 that referenced this pull request Aug 13, 2026
Updated [Roslynator.Analyzers](https://github.com/dotnet/roslynator)
from 4.15.0 to 4.16.0.

<details>
<summary>Release notes</summary>

_Sourced from [Roslynator.Analyzers's
releases](https://github.com/dotnet/roslynator/releases)._

## 4.16.0

### Added

- [CLI] Suppress error code from Roslynator when it detects issues in
code but runs successfully
([PR](dotnet/roslynator#1756) by @​mdrybak)

### Fixed

- Fix analyzer
[RCS1118](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1118)
to not report local variable passed as 'in' argument
([PR](dotnet/roslynator#1782) by @​NoahStolk)
- Fix analyzer
[RCS1074](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1074)
([PR](dotnet/roslynator#1768) by @​cbersch)
- Fix enum contained flags check for partial matches in
[RCS1258](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1258)
([PR](dotnet/roslynator#1740) by @​ovska)
- Fix analyzer
[RCS1146](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1146)
([PR](dotnet/roslynator#1747))
- Fix analyzer
[RCS1194](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1194)
([PR](dotnet/roslynator#1733))
- Fix analyzer
[RCS1060](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1060)
to ignore classes marked with `file` modifier
([PR](dotnet/roslynator#1777) by @​cbersch)
- Fix analyzer
[RCS1231](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1231)
([PR](dotnet/roslynator#1774) by @​cbersch)
- Fix analyzer
[RCS1246](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1246)
for conditional access expressions
([PR](dotnet/roslynator#1772 by @​krajek))
- [CLI] Fix `fix` command ignoring `--include` / `--exclude` file filter
([PR](dotnet/roslynator#1758) by @​hashiiiii)
- [CLI] Fix loading of projects and solutions on .NET 10 SDK
([PR](dotnet/roslynator#1783))


Commits viewable in [compare
view](dotnet/roslynator@v4.15.0...v4.16.0).
</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
renebentes pushed a commit to renebentes/3054 that referenced this pull request Aug 13, 2026
…232)

Updated
[Roslynator.CodeAnalysis.Analyzers](https://github.com/dotnet/roslynator)
from 4.15.0 to 4.16.0.

<details>
<summary>Release notes</summary>

_Sourced from [Roslynator.CodeAnalysis.Analyzers's
releases](https://github.com/dotnet/roslynator/releases)._

## 4.16.0

### Added

- [CLI] Suppress error code from Roslynator when it detects issues in
code but runs successfully
([PR](dotnet/roslynator#1756) by @​mdrybak)

### Fixed

- Fix analyzer
[RCS1118](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1118)
to not report local variable passed as 'in' argument
([PR](dotnet/roslynator#1782) by @​NoahStolk)
- Fix analyzer
[RCS1074](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1074)
([PR](dotnet/roslynator#1768) by @​cbersch)
- Fix enum contained flags check for partial matches in
[RCS1258](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1258)
([PR](dotnet/roslynator#1740) by @​ovska)
- Fix analyzer
[RCS1146](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1146)
([PR](dotnet/roslynator#1747))
- Fix analyzer
[RCS1194](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1194)
([PR](dotnet/roslynator#1733))
- Fix analyzer
[RCS1060](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1060)
to ignore classes marked with `file` modifier
([PR](dotnet/roslynator#1777) by @​cbersch)
- Fix analyzer
[RCS1231](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1231)
([PR](dotnet/roslynator#1774) by @​cbersch)
- Fix analyzer
[RCS1246](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1246)
for conditional access expressions
([PR](dotnet/roslynator#1772 by @​krajek))
- [CLI] Fix `fix` command ignoring `--include` / `--exclude` file filter
([PR](dotnet/roslynator#1758) by @​hashiiiii)
- [CLI] Fix loading of projects and solutions on .NET 10 SDK
([PR](dotnet/roslynator#1783))


Commits viewable in [compare
view](dotnet/roslynator@v4.15.0...v4.16.0).
</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
renebentes pushed a commit to renebentes/3054 that referenced this pull request Aug 13, 2026
Updated
[Roslynator.Formatting.Analyzers](https://github.com/dotnet/roslynator)
from 4.15.0 to 4.16.0.

<details>
<summary>Release notes</summary>

_Sourced from [Roslynator.Formatting.Analyzers's
releases](https://github.com/dotnet/roslynator/releases)._

## 4.16.0

### Added

- [CLI] Suppress error code from Roslynator when it detects issues in
code but runs successfully
([PR](dotnet/roslynator#1756) by @​mdrybak)

### Fixed

- Fix analyzer
[RCS1118](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1118)
to not report local variable passed as 'in' argument
([PR](dotnet/roslynator#1782) by @​NoahStolk)
- Fix analyzer
[RCS1074](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1074)
([PR](dotnet/roslynator#1768) by @​cbersch)
- Fix enum contained flags check for partial matches in
[RCS1258](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1258)
([PR](dotnet/roslynator#1740) by @​ovska)
- Fix analyzer
[RCS1146](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1146)
([PR](dotnet/roslynator#1747))
- Fix analyzer
[RCS1194](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1194)
([PR](dotnet/roslynator#1733))
- Fix analyzer
[RCS1060](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1060)
to ignore classes marked with `file` modifier
([PR](dotnet/roslynator#1777) by @​cbersch)
- Fix analyzer
[RCS1231](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1231)
([PR](dotnet/roslynator#1774) by @​cbersch)
- Fix analyzer
[RCS1246](https://josefpihrt.github.io/docs/roslynator/analyzers/RCS1246)
for conditional access expressions
([PR](dotnet/roslynator#1772 by @​krajek))
- [CLI] Fix `fix` command ignoring `--include` / `--exclude` file filter
([PR](dotnet/roslynator#1758) by @​hashiiiii)
- [CLI] Fix loading of projects and solutions on .NET 10 SDK
([PR](dotnet/roslynator#1783))


Commits viewable in [compare
view](dotnet/roslynator@v4.15.0...v4.16.0).
</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

RCS1231 shouldn't trigger when parameter is params

2 participants