Runtime90357 6012

[manfred-brands]

Fixes #6012
See also dotnet/runtime#90357

Prevents IndexOutOfRangeException, but also checks formats of non-formatting methods.

[codecov]

Codecov Report

Merging #6885 (046190a) into main (7e4877c) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 100.00%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #6885   +/-   ##
=======================================
  Coverage   96.39%   96.39%           
=======================================
  Files        1403     1403           
  Lines      330977   331069   +92     
  Branches    10890    10894    +4     
=======================================
+ Hits       319056   319150   +94     
+ Misses       9187     9186    -1     
+ Partials     2734     2733    -1     

[tarekgh]

Fixes dotnet/runtime#90357

Please don't resolve this issue if we merged this PR. We need to have some changes in the runtime repo to remove suppressing AD0001 and ensure porting the fixes to the 8.0 release branch.

CC @buyaa-n

[manfred-brands]

Fixes dotnet/runtime#90357

Please don't resolve this issue if we merged this PR. We need to have some changes in the runtime repo to remove suppressing AD0001 and ensure porting the fixes to the 8.0 release branch.

CC @buyaa-n

Updated comment to not fix that issue

[manfred-brands]

Not sure why the builds fail. It has probably to do with the new description added.

[buyaa-n]

Not sure why the builds fail. It has probably to do with the new description added.

Looks it needs to run msbuild /t:pack and push updates

[jeffhandley]

Once CI is fully green and @buyaa-n has signed off on the PR, I approve of this for RC2.

@carlossanlop, when it reaches that point, can you please shepherd this through Tactics and into the RC2 builds?

[carlossanlop]

Yes, no problem. Assuming this PR is done before Sept 18th (RC2 snap day), your approval @jeffhandley is sufficient (no Tactics involvement needed).

Note: the /backport to <branch> bot does not work in this repo unfortunately, so the backport needs to be created manually. @manfred-brands you'll need to cherry-pick these changes into release/8.0.1xx and create a new PR (do that after merging this PR).

[manfred-brands]

Not sure why the builds fail. It has probably to do with the new description added.

Looks it needs to run msbuild /t:pack and push updates

@buyaa-n That did seem to do the trick, but the only change is removing a line for another analyzer from RulesMissingDocumentation.md, which seems completely unrelated to this PR.

[buyaa-n]

Than you @manfred-brands LGTM

[buyaa-n]

Note: the /backport to bot does not work in this repo unfortunately, so the backport needs to be created manually. @manfred-brands you'll need to cherry-pick these changes into release/8.0.1xx and create a new PR (do that after merging this PR).

@carlossanlop for analyzers repo we used to merge PRs into release branch first then it flows automatically to main, is that same this year or now it's changed? CC @mavasani

[carlossanlop]

@buyaa-n @mavasani since this is the only change we intend to backport to release/8.0.1xx (so far), I propose we do the same as in dotnet/runtime: Merge to main first, then backport to the servicing branch.

[buyaa-n]

Merged, @manfred-brands we do squash merge so if you planning to put up a port to 8.0 please cherry pick squashed commit.

Or I can do that later

[buyaa-n]

/backport to release/8.0.1xx

[github-actions]

Started backporting to release/8.0.1xx: https://github.com/dotnet/roslyn-analyzers/actions/runs/5980358523

[buyaa-n]

@manfred-brands we do squash merge so if you planning to put up a port to 8.0 please cherry pick squashed commit.

Never mind, thanks to #6892 now we have a bot for backporting.