Added serializing object property to JSON#936
Merged
Conversation
adamsitnik
reviewed
Oct 13, 2019
Contributor
|
With your fix from https://github.com/dotnet/corefx/issues/41638, is the performance of |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
@ahsonkhan There is still some gap, though considering that But I haven't looked further into it, so it's possible there are still other optimizations to be had. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to dotnet/corefx#41753 and https://github.com/dotnet/corefx/issues/41638.
This is a case where System.Text.Json currently has a performance issue, so I think it makes sense to add a benchmark for it, independently of whether the PR dotnet/corefx#41753 is accepted into corefx.