Fix reminder churn test determinism - #9997
Merged
Merged
Conversation
Adjust the churn reminder assertions and waiting logic to match the DiagnosticListener-based synchronization path. Replace the remaining fixed-delay gates in the Azure and Cosmos 2J churn tests with observed reminder activity and restore enough timeout budget for churn scenarios. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root cause: the post-82fed1726dfa901dff008048204f9a0ce01ae476 tests mixed the new observer-driven waits with old timing assumptions. This lowers the guaranteed DEFAULT_REMINDER floor from 9 to 8, removes the last fixed-delay gate from the Azure/Cosmos 2J churn tests, and gives churn scenarios a dedicated timeout budget. Validation: dotnet build Orleans.slnx; ReminderEventsTests; focused Azure reminder filters for Rem_Azure_1J_MultiGrainMultiReminders and Rem_Azure_2J_MultiGrainMultiReminders.
Microsoft Reviewers: Open in CodeFlow