test(analyzers): raise compiler tooling coverage

[ReubenBond]

Problem

Compiler-tooling coverage misses substantial analyzer/code-fix behavior and leaves TypeSymbolResolver's highest-complexity paths largely unverified. The analyzer project also lacks first-class CI traits, so its existing contract-version suite does not participate in the canonical coverage selection.

Solution

• Tag analyzer tests with the canonical BVT, provider, and area traits.
• Add behavior-focused coverage for contract code-fix guards, CRLF preservation, and non-constant ConfigureAwaitOptions expressions.
• Add direct resolver tests for aliases, nested/generic syntax, fallback indexing, metadata identity, ambiguity, cancellation, and proxy invariants.
• Make simple-name assembly ambiguity terminal and clear failed proxy results.
• Replace duplicated primitive-type switches with shared lookups and remove an unused resolver overload.

Rationale

The three named hotspot files move from 14.8% line / 3.9% branch coverage to 86.3% line / 77.7% branch coverage, with CRAP>30 methods reduced from 23 to 6. TypeSymbolResolver.cs reaches 90.9% line / 85.7% branch coverage, while its primitive helper complexity drops from 80/72 to 10/1.

Part of #10857.

Microsoft Reviewers: Open in CodeFlow

[Copilot]

Copilot review overview

Review tier: Lite
Findings: None

What changed in this PR

This PR increases test coverage for Orleans compiler tooling (analyzers/code fixes and code generator type resolution) while also tightening TypeSymbolResolver behavior around assembly-name ambiguity and proxy-interface validation.

Changes:

• Adds a comprehensive new test suite for TypeSymbolResolver, covering metadata identity resolution, fallback behavior, ambiguity handling, and cancellation.
• Expands analyzer/code-fix tests to cover code-fix registration guards, CRLF preservation, and additional ConfigureAwaitOptions expression scenarios.
• Refactors TypeSymbolResolver primitive-type handling via shared lookup tables and removes an unused overload; makes simple-name assembly ambiguity terminal and clears failed proxy results.

File	Description
test/​Orleans.CodeGenerator.Tests/​TypeSymbolResolverTests.cs	New direct unit tests covering TypeSymbolResolver high-complexity and edge-case paths.
test/​Orleans.Analyzers.Tests/​GrainInterfaceVersionAnalyzerTest.cs	Adds tests for code-fix guard behavior and CRLF-preserving contract file updates.
test/​Orleans.Analyzers.Tests/​ConfigureAwaitAnalyzerTest.cs	Adds diagnostic/no-diagnostic coverage for non-constant and partially-known ConfigureAwaitOptions expressions.
test/​Orleans.Analyzers.Tests/​AssemblyInfo.cs	Adds canonical test suite/provider/area traits so analyzer tests participate in the intended CI lanes.
src/​Orleans.CodeGenerator/​TypeSymbolResolver.cs	Refines assembly/type resolution semantics, proxy resolution output behavior, and consolidates primitive-type mappings.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[github-actions]

Code coverage

79.41% line coverage - 100,568 / 126,644 lines

Coverage details

• Source files: 1,662
• Scope: every CI test matrix job, including providers, CodeGen, .NET 8/10, Linux, Windows, and macOS
• Sources: maintained repository code under src/ loaded by the complete CI test scope
• Commit: 6a8cb86ce7
• View the test run and merged coverage artifact
• View the coverage reporting run