chore: remove static Orleans meter#10201
Conversation
|
@ReubenBond I'd like your feedback on the compatibility fallback constructors in this PR. Right now, after removing the static : this(dimensions, new Meter("Microsoft.Orleans"))That feels questionable: it avoids the static meter, but it still creates ad-hoc meters outside Would you prefer that we make this a breaking cleanup instead and add/require an |
|
@Meir017 Let's make a compilation break and remove the back-compat ctor |
|
Applied this in The affected projects build locally for |
e8b4476 to
0d9cc42
Compare
|
Rebased onto current main and pushed a fix for the broad CI failures: #10199 had already added an internal \DefaultQueueAdapterReceiverMonitor(ReceiverMonitorDimensions, OrleansInstruments), and this PR also added a public constructor with the same signature, causing CS0111 across the build. Removed the duplicate internal constructor in \ |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
f970ad8 to
51dad70
Compare
closes #9608 by removing the static Orleans meter entirely.
This deletes
Orleans.Runtime.Instruments, removes the generated API surface for it, converts transaction statistics to useOrleansInstrumentswhen resolved from DI, and leaves direct-construction compatibility paths on per-instance meters instead of a shared static meter.Depends on #10199 and #10200 to finish moving the remaining provider-created stream monitors to DI-created meters.
Microsoft Reviewers: Open in CodeFlow