feat: Add grain_type tag to app-request timeout/cancel counters#10178
Merged
ReubenBond merged 1 commit intoJun 4, 2026
Merged
Conversation
Cluster7ck
force-pushed
the
metrics/grain-type-app-request-counters
branch
from
1162f04 to
37776f2
Compare
Cluster7ck
changed the title
Tag orleans-app-requests-timedout and orleans-app-requests-canceled with the target grain implementation type (msg.TargetGrain.Type), so timeouts and cancellations can be broken down by grain type. Default grain types are reported as "unknown". Also fix a mis-wiring in CallbackData.OnCancellation(): it incremented the timed-out counter instead of the canceled counter, so cancellations were counted as timeouts and orleans-app-requests-canceled never emitted.
Cluster7ck
force-pushed
the
metrics/grain-type-app-request-counters
branch
from
37776f2 to
1b59e8b
Compare
ReubenBond
approved these changes
Jun 4, 2026
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a
grain_typelabel to the per-request counters onApplicationRequestInstruments:orleans-app-requests-timedoutorleans-app-requests-canceledBug fix included
CallbackData.OnCancellation()incremented the timed-out counter instead of the canceled counter.