fix(nats): Validate StorageType and pin NATS test endpoint (follow-up to #10028)#10176
Merged
ReubenBond merged 2 commits intoJun 8, 2026
Merged
Conversation
Cluster7ck
force-pushed
the
feat/nats-storage-type-validation
branch
from
cac3308 to
f7247b2
Compare
Reject StorageType values that are not defined StreamConfigStorage enum members before they reach JetStream, throwing OrleansConfigurationException with the valid values (File/Memory). Addresses review feedback on dotnet#10028.
Addresses PR dotnet#10028 review: use NatsTestConstants.NatsClientOptions for both the connection manager options and the verification connection so the stream is created against and queried from the same pinned server endpoint.
Cluster7ck
force-pushed
the
feat/nats-storage-type-validation
branch
from
f7247b2 to
652bd64
Compare
Cluster7ck
changed the title
This was referenced Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #10028, addressing review comments.
Changes
NatsStreamOptionsValidatornow rejects undefinedStreamConfigStorageenum values.Use
NatsTestConstants.NatsClientOptionsto align with existing tests.