Preserve Cosmos reminder ETags for stale delete checks#10041
Merged
Conversation
ReubenBond
force-pushed
the
reubenbond/cosmos-reminder-etag-delete
branch
from
b31567d to
a92766c
Compare
ReubenBond
changed the title
Preserve reminder ETags when converting entries to Cosmos entities and verify the current item ETag before delete. Update the shared stale-ETag test to perform a real row update before validating stale delete behavior. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ReubenBond
force-pushed
the
reubenbond/cosmos-reminder-etag-delete
branch
from
a92766c to
f8164e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split out from #9993.
Why
Cosmos reminder updates should preserve the reminder ETag so existing conditional operations can detect stale writes/deletes correctly. The shared stale-ETag reminder table test also needs to perform a real update before validating stale delete behavior.
What changed
CosmosReminderTable.RemoveRowcontinues to issue a direct conditional delete usingItemRequestOptions.IfMatchEtag; this PR no longer performs a pre-delete read to validate the ETag.Validation
dotnet test test\Extensions\Orleans.Cosmos.Tests\Orleans.Cosmos.Tests.csproj -nologo --filter "FullyQualifiedName~CosmosRemindersTableTests"(compiled; Cosmos precondition skips in local environment)Microsoft Reviewers: Open in CodeFlow