Move reference assemblies into obj (again)#7075
Merged
Merged
Conversation
Contributor
|
Do we have a proper fix for that work item? It looks like someone closed because after reverting moving ref assemblies into obj, the problem went away...wouldn't this essentially just reopen that, or did we change something else? |
Member
Author
|
Per #6543 (comment), this was blocked on project system and IDE work that is now complete. However, I plan to run an exp/ insertion and poke around a bit before undrafting this. |
Member
Author
|
I manually verified a build of OrchardCore and the regression AB#1361354 that caused us to back this out before, and this looks good to me now. |
rokonec
approved these changes
Nov 30, 2021
Forgind
added
the
merge-when-branch-open
rainersigwald
added a commit
to dotnet/sdk
that referenced
this pull request
Dec 3, 2021
Specifically these will fail due to an extra file in bin before the VS MSBuild has dotnet/msbuild#7075.
dotnet-maestro Bot
added a commit
to dotnet/sdk
that referenced
this pull request
Dec 7, 2021
[release/6.0.2xx] Update dependencies from dotnet/msbuild - Update VS package version - Stop assuming ref assemblies are in output folder They are moved--see dotnet/msbuild#6543 - fixup! Stop assuming ref assemblies are in output folder - fixup! Stop assuming ref assemblies are in output folder - fixup! fixup! Stop assuming ref assemblies are in output folder - Only test ref outputs on newer MSBuild Specifically these will fail due to an extra file in bin before the VS MSBuild has dotnet/msbuild#7075. - fixup! Only test ref outputs on newer MSBuild
This was referenced Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6718
Fixes #6543.