[Static graph] Support transitive project references in static graph#5287
Closed
cdmihai wants to merge 8 commits into
Closed
[Static graph] Support transitive project references in static graph#5287cdmihai wants to merge 8 commits into
cdmihai wants to merge 8 commits into
Conversation
cdmihai
force-pushed
the
transitiveProjectReferences
branch
from
88ee3f0 to
aca2f4b
Compare
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
cdmihai
force-pushed
the
transitiveProjectReferences
branch
from
aca2f4b to
fe6e48a
Compare
Forgind
reviewed
Apr 23, 2020
Co-Authored-By: Rainer Sigwald <raines@microsoft.com>
rainersigwald
approved these changes
Apr 28, 2020
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
andrewchoi5
approved these changes
May 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transitive project references are a thing now. Added support to static graph, so that buildxl and qb can avoid adding the transitive refs.
This PR is independent of #5222. Ideally, review this one first, as QB has a stronger dependency on this PR than on #5222.
Design
AddTransitiveProjectReferencesInStaticGraphto true. The sdk does this automatically in Microsoft.Managed.After.Targets.