Skip to content

Add environment variables for governance detection - #13920

Merged
ViktorHofer merged 2 commits into
mainfrom
ViktorHofer-patch-1
Jun 2, 2026
Merged

Add environment variables for governance detection#13920
ViktorHofer merged 2 commits into
mainfrom
ViktorHofer-patch-1

Conversation

@ViktorHofer

Copy link
Copy Markdown
Member

Skip CG and CodeQL on public quarantine pipeline

Copilot AI review requested due to automatic review settings June 2, 2026 13:12
@ViktorHofer
ViktorHofer enabled auto-merge (squash) June 2, 2026 13:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the quarantined-test re-validation Azure Pipelines definition to explicitly control whether security/governance scanning runs, aligning the quarantine pipeline behavior with public-vs-internal execution constraints.

Changes:

  • Add pipeline variables intended to disable Component Governance detection.
  • Add pipeline variables intended to disable CodeQL analysis.
Show a summary per file
File Description
azure-pipelines/quarantine.yml Adds variables to control/disable CG and CodeQL execution for the quarantine pipeline.

Copilot's findings

  • Files reviewed: 1/1 changed files
  • Comments generated: 1

Comment thread azure-pipelines/quarantine.yml Outdated

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: Clean — no issues found.

Verified against existing repo conventions:

  • Convention match: vmr-sb-validation.yml uses the identical pattern (skipComponentGovernanceDetection: true + Codeql.Enabled: false) with the same values. .vsts-dotnet-exp-perf.yml also disables CodeQL. This is an established practice for non-shipping pipelines in this repo.
  • Variable correctness: Both variable names and values are correct for Azure Pipelines (skipComponentGovernanceDetection is case-sensitive and true is the right value; Codeql.Enabled: false is standard).
  • Security: The quarantine pipeline is a scheduled test-revalidation pipeline that produces no shipping artifacts. CG (supply-chain scanning) and CodeQL (security scanning) provide no value here — the main CI pipeline still covers those concerns for production code paths.
  • Scope: Minimal, well-targeted change with helpful inline comments explaining the rationale.

LGTM.

Generated by Expert Code Review (on open) for issue #13920 · ● 1.4M

@ViktorHofer
ViktorHofer merged commit 44b2bab into main Jun 2, 2026
10 checks passed
@ViktorHofer
ViktorHofer deleted the ViktorHofer-patch-1 branch June 2, 2026 14:43
This was referenced Aug 11, 2026
This was referenced Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants