Add environment variables for governance detection - #13920
Merged
Conversation
AlesProkop
approved these changes
Jun 2, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the quarantined-test re-validation Azure Pipelines definition to explicitly control whether security/governance scanning runs, aligning the quarantine pipeline behavior with public-vs-internal execution constraints.
Changes:
- Add pipeline variables intended to disable Component Governance detection.
- Add pipeline variables intended to disable CodeQL analysis.
Show a summary per file
| File | Description |
|---|---|
| azure-pipelines/quarantine.yml | Adds variables to control/disable CG and CodeQL execution for the quarantine pipeline. |
Copilot's findings
- Files reviewed: 1/1 changed files
- Comments generated: 1
Contributor
There was a problem hiding this comment.
Review: Clean — no issues found.
Verified against existing repo conventions:
- Convention match:
vmr-sb-validation.ymluses the identical pattern (skipComponentGovernanceDetection: true+Codeql.Enabled: false) with the same values..vsts-dotnet-exp-perf.ymlalso disables CodeQL. This is an established practice for non-shipping pipelines in this repo. - Variable correctness: Both variable names and values are correct for Azure Pipelines (
skipComponentGovernanceDetectionis case-sensitive andtrueis the right value;Codeql.Enabled: falseis standard). - Security: The quarantine pipeline is a scheduled test-revalidation pipeline that produces no shipping artifacts. CG (supply-chain scanning) and CodeQL (security scanning) provide no value here — the main CI pipeline still covers those concerns for production code paths.
- Scope: Minimal, well-targeted change with helpful inline comments explaining the rationale.
LGTM.
Generated by Expert Code Review (on open) for issue #13920 · ● 1.4M
This was referenced Jun 3, 2026
This was referenced Aug 11, 2026
Bump Microsoft.Build from 18.4.0 to 18.9.6
SkylineCommunications/Skyline.DataMiner.CICD.Packages#172
Open
This was referenced Aug 18, 2026
Closed
Open
This was referenced Aug 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skip CG and CodeQL on public quarantine pipeline