Skip to content

Avoid checkout in insertion pipeline - #13887

Merged
rainersigwald merged 1 commit into
mainfrom
rainersigwald/vs-insertion-skip-checkout
May 28, 2026
Merged

Avoid checkout in insertion pipeline#13887
rainersigwald merged 1 commit into
mainfrom
rainersigwald/vs-insertion-skip-checkout

Conversation

@rainersigwald

@rainersigwald rainersigwald commented May 27, 2026

Copy link
Copy Markdown
Member

This should save something like 30s/insertion, which isn't important, and just generally avoid unnecessary work.

This should save something like 30s/insertion, which isn't important,
and just generally avoid unnecessary work.
Copilot AI review requested due to automatic review settings May 27, 2026 21:11
@rainersigwald rainersigwald added the Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself. label May 27, 2026
@rainersigwald rainersigwald self-assigned this May 27, 2026
@rainersigwald
rainersigwald requested a review from a team May 27, 2026 21:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Visual Studio insertion Azure Pipeline to skip repository checkout in jobs that only use downloaded pipeline artifacts and inline scripts, reducing unnecessary work and slightly improving insertion runtime.

Changes:

  • Disable checkout in the RetainBuild stage job to avoid fetching sources when only inline PowerShell tasks run.
  • Disable checkout in the VSInsertion stage job to avoid fetching sources when the job operates on pipeline artifacts and tasks.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

24/24 dimensions clean — no findings.

Verified that neither job references source files: no $(Build.SourcesDirectory) or $(System.DefaultWorkingDirectory) usage. All tasks use pipeline artifacts ($(Build.ArtifactStagingDirectory), $(Pipeline.Workspace)) and inline scripts. The checkout: none optimization is safe and well-documented with the inline comment.

Generated by Expert Code Review (on open) for issue #13887 · ● 1.4M

@rainersigwald
rainersigwald enabled auto-merge (squash) May 27, 2026 21:53
@rainersigwald
rainersigwald merged commit 2fae215 into main May 28, 2026
17 checks passed
@rainersigwald
rainersigwald deleted the rainersigwald/vs-insertion-skip-checkout branch May 28, 2026 06:45
This was referenced Aug 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Our Own Build Problems affecting the build or build infrastructure of the MSBuild repo itself.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants