Stable branding for 18.8 release - #13883
Conversation
There was a problem hiding this comment.
Pull request overview
Final-brands the 18.8 release by switching the pre-release label from preview to servicing and adding DotNetFinalVersionKind=release to eng/Versions.props, consistent with the documented servicing-branch release process. The PR also appears to inadvertently add a scratch .NET 4.7.2 console project (scratch-net472-test/) used for local experimentation around Path/File/Directory semantics.
Changes:
- Set
DotNetFinalVersionKindtoreleaseand switchPreReleaseVersionLabelfrompreviewtoservicingfor 18.8 final branding. - Add an inline comment intended to force a forward-flow merge conflict on
VersionPrefix. - Add an unrelated
scratch-net472-test/console project (likely accidental).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| eng/Versions.props | Sets DotNetFinalVersionKind=release and changes pre-release label to servicing for the stable 18.8 branding. |
| scratch-net472-test/Program.cs | Adds a small NET472 test program exercising Path.GetFullPath/File.Exists/Directory.Exists with invalid paths — appears unrelated to the release. |
| scratch-net472-test/Net472PathSemantics.csproj | Project file for the above scratch console app — appears unrelated to the release. |
|
@rainersigwald pls force merge (I cancelded the previous 18.8.0 run so no package conflicts with 0 version) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Expert Review — Stable branding for 18.8 release
| Dimension | Verdict |
|---|---|
| Scope & PR Discipline | |
| Build Infrastructure Care | ✅ LGTM — Branding change follows established pattern |
| All other 22 dimensions | ✅ N/A or LGTM (no code/behavior changes) |
Summary
The eng/Versions.props change correctly applies stable branding (DotNetFinalVersionKind=release, PreReleaseVersionLabel=servicing) with the intentional forward-flow conflict comment. This follows the known release branding pattern.
Action required: Remove the scratch-net472-test/ directory (2 files) which is an unrelated developer scratch project accidentally included in this PR. These files are not part of any solution, not gitignored, and have no relation to release branding.
Generated by Expert Code Review (on open) for issue #13883 · ● 2M
|
Just realized this targeted |
|
/backport to vs18.8 |
|
Started backporting to |
#13883 targeted `main` instead of `vs18.8`, and already built so we can't use the 18.8.0 version.
We can't use the 18.8.0 version because #13883 targeted `main` instead of `vs18.8`, and already built. --------- Co-authored-by: Veronika Ovsyannikova <veronikao@microsoft.com> Co-authored-by: Rainer Sigwald <raines@microsoft.com>
Branding for 18.8 release