Skip to content

Aloha System.Maui!#4

Merged
samhouts merged 3 commits into
buildfrom
aloha
May 19, 2020
Merged

Aloha System.Maui!#4
samhouts merged 3 commits into
buildfrom
aloha

Conversation

@samhouts

Copy link
Copy Markdown
Contributor

As the first step in this journey, let's bask in the sun for a minute and see what System.Maui might look like.

🌞🌞😎🌞🌞

@samhouts samhouts requested a review from jsuarezruiz as a code owner May 15, 2020 19:54
@jsuarezruiz

Copy link
Copy Markdown
Contributor

Aloha System.Maui!

flower-maui

@jsuarezruiz jsuarezruiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have problems loading System.Maui.Controls.Issues.Shared.shproj and System.Maui.Core.UITests.Shared.shproj (shared projects). The problem is that we have renamed the project name but in the shproj it is still trying to import "Xamarin.Forms...". Changing the projitems name in these shproj fix the problem.

Could we add the Build process for PRs in the repo?

@samhouts samhouts merged commit 6c19de4 into build May 19, 2020
@PureWeen PureWeen deleted the aloha branch May 19, 2020 19:07
@kristinx0211 kristinx0211 mentioned this pull request Feb 11, 2022
mattleibow pushed a commit that referenced this pull request Jun 18, 2022
* Create build.yml (#4)

* Create build.yml

* Update build.yml

* Update build.yml

* Removed Blazor projects from solution.

* Added a solution to be used for ci/cd on mac build agents.

* Update build.yml

* Moved ci/ci solution to build folder.

* Update build.yml

* Started work on nuspec files.

* Update build.yml

* Fixed paths in Build solution.

* Update build.yml

* Update build.yml

* Fixed nuspec files.

* Fixed another path.

* More path updates.

* Added additional nuspec files.

* Fixed path.

* Try secret

* Tried secrets 2

* Fixed nuspec file.

* Updated the workflows.

* Updated workflows again.

* Switched from run_number to run_id (#5)
mattleibow pushed a commit that referenced this pull request Jun 18, 2022
* Create build.yml

* Update build.yml

* Update build.yml

* Removed Blazor projects from solution.

* Added a solution to be used for ci/cd on mac build agents.

* Update build.yml

* Moved ci/ci solution to build folder.

* Update build.yml

* Started work on nuspec files.

* Update build.yml

* Fixed paths in Build solution.

* Update build.yml

* Update build.yml

* Fixed nuspec files.

* Fixed another path.

* More path updates.

* Added additional nuspec files.

* Fixed path.

* Try secret

* Tried secrets 2

* Fixed nuspec file.

* Updated the workflows.

* Updated workflows again.
@samhouts samhouts added the area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions label Jul 19, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 27, 2023
JanKrivanek added a commit that referenced this pull request Apr 15, 2026
- Fix #1 (CRITICAL): Shell injection in evaluate job - use env var
  indirection for skills_path and rename GITHUB_TOKEN to COPILOT_TOKEN
- Fix #4: PowerShell here-string injection - use env:SKILL_DIRS
- Fix #5: Code-fence injection - escape triple backticks in output
- Fix #6: Delete old agent .md files (keep .agent.md versions)
- Fix #7: Shell injection in static-check heredoc - use env var
- Fix #8: Direct expression interpolation - use env: block for event props
- Fix #9: Heredoc EOF spoofing - use random delimiter
- Fix #10: Missing pipe-escaping for skillName/scenarioName
- Fix #11: Renamed Copilot token env var to COPILOT_TOKEN
- Fix #13: Token rotation entropy - mix in github.run_id
- Fix #14: Fix misleading inline comment for icon logic
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-infrastructure CI, Maestro / Coherency, upstream dependencies/versions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants