Skip to content

Fix Windows Shell tests failure in June 8 Candidate#35898

Merged
kubaflo merged 4 commits into
dotnet:inflight/candidatefrom
devanathan-vaithiyanathan:fix-candidate-34630
Jun 16, 2026
Merged

Fix Windows Shell tests failure in June 8 Candidate#35898
kubaflo merged 4 commits into
dotnet:inflight/candidatefrom
devanathan-vaithiyanathan:fix-candidate-34630

Conversation

@devanathan-vaithiyanathan

Copy link
Copy Markdown
Contributor

Issue Details

Due to PR #34630, some shell tests are failed in the June 8 Candidate

Description of changes

Replaced AddDisplayedPageObserver with per-ShellContent PropertyChanged subscription filtered to ShellContent.ContentProperty only (same pattern used on iOS). This fires only when the page content actually changes, never on tab switches. Event subscriptions are managed across SetVirtualView, OnItemsCollectionChanged, and DisconnectHandler to handle dynamic tab additions/removals.

Failed test case

  • ObservableCollectionChangeListView
  • NoDuplicateTitleViews[Shell]
  • NoDuplicateTitleViews[TitleView]
  • NavigatingBackAndForthDoesNotCrash
  • NavigatingBackToAlreadySelectedTopTabDoesntCrash
  • ShellNavigationFeatureTests - All test cases except first 3
  • ShellItemItemsClearTests
  • ShellColorsResetOnNavigation
  • TabBarVisibilityShowsOnPage2UsingBinding
  • TabBarVisibilityHidesOnPage2UsingBindingn
  • NavBarUpdatesWhenSwitchingShellContent
  • HideActiveShellContent
  • UpdateSearchHandlerMenuItemForTabNavigation

@dotnet-policy-service dotnet-policy-service Bot added the partner/syncfusion Issues / PR's with Syncfusion collaboration label Jun 12, 2026
@vishnumenon2684 vishnumenon2684 added the community ✨ Community Contribution label Jun 12, 2026
@github-actions github-actions Bot added area-controls-shell Shell Navigation, Routes, Tabs, Flyout platform/windows labels Jun 12, 2026
@sheiksyedm

Copy link
Copy Markdown
Contributor

/azp run maui-pr-uitests , maui-pr-devicetests

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@devanathan-vaithiyanathan devanathan-vaithiyanathan marked this pull request as ready for review June 16, 2026 12:18
@kubaflo kubaflo merged commit 11df4f9 into dotnet:inflight/candidate Jun 16, 2026
5 of 36 checks passed
@github-actions github-actions Bot added this to the .NET 10 SR9 milestone Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-controls-shell Shell Navigation, Routes, Tabs, Flyout community ✨ Community Contribution partner/syncfusion Issues / PR's with Syncfusion collaboration platform/windows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants