Skip to content

[Inflight regression] Fixed Test failures ModalTabbedPagePushAsyncShouldOverlayBottomNavigationView and GroupedCollectionViewScrollToIndexScrollsToCorrectItem#35823

Merged
kubaflo merged 3 commits into
dotnet:inflight/candidatefrom
Dhivya-SF4094:fix-Shadow_SetEnabledStateToFalse_VerifyScreenshot
Jun 9, 2026
Merged

Conversation

@Dhivya-SF4094

Copy link
Copy Markdown
Contributor

This pull request improves both the scrolling logic for grouped data in Android's MauiRecyclerView and the reliability and clarity of UI tests for modal navigation with tabbed pages. The most important changes are grouped below:

Android RecyclerView scrolling improvements:

  • Added a direct mapping from flat data indices to RecyclerView adapter positions for grouped data, improving performance and correctness when scrolling to items by flat index. This avoids ambiguity and unnecessary item comparisons when items in different groups are equal.
  • Refactored the logic so that flat index requests no longer materialize the item for position lookup, further reducing overhead and potential errors.

UI test improvements for modal tabbed navigation:

  • Reorganized and clarified the test methods for modal tabbed page navigation: the tests are now ordered, more clearly named, and include explicit steps to reset state between tests, increasing reliability and maintainability. (Issue35331.cs)
  • Swapped the order and logic of the two test methods to better separate concerns: one test now verifies that returning from a detail page restores the tab bar, and the other confirms that the pushed detail page overlays the tab bar as expected. (Issue35331.cs)

@github-actions github-actions Bot added area-controls-collectionview CollectionView, CarouselView, IndicatorView platform/android labels Jun 9, 2026
@Dhivya-SF4094 Dhivya-SF4094 marked this pull request as ready for review June 9, 2026 12:56
@kubaflo kubaflo merged commit fb197a1 into dotnet:inflight/candidate Jun 9, 2026
14 of 41 checks passed
@github-actions github-actions Bot added this to the .NET 10.0 SR8 milestone Jun 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-controls-collectionview CollectionView, CarouselView, IndicatorView platform/android

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants