[release/10.0.1xx-sr7] Revert - Fix TalkBack not correctly narrating RadioButtons with Content#35694
Merged
PureWeen merged 1 commit intoJun 2, 2026
Conversation
…nt (#35625) <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Issue details: A regression was introduced by PR #[34521](#34521) on Android. It set RadioButton accessibility metadata (ClassName, Checkable, Checked) on AccessibilityNodeInfoCompat during TalkBack. The bool setter for Checked no longer exists in AndroidX Core 1.17.x (API changed), causing a MissingMethodException at runtime. This mainly affects .NET 10 MAUI packages that compile against AndroidX Core 1.16.0.3. ### Description of changes: Fully reverts PR #[34521](#34521). Removes the IRadioButton accessibility block (ClassName, Checkable, Checked) and the cached s_radioButtonClassName field from SemanticExtensions.cs. Reverts RadioButton.UpdateSemantics back to using ContentAsString() and removes the GetSemanticDescriptionFromContent() and TryGetSemanticDescription() helpers. Also removes the two device tests added for issue #[34322](#34322) and their helper methods. ### Issues Fixed <!-- Please make sure that there is a bug logged for the issue being fixed. The bug should describe the problem and how to reproduce it. --> Fixes #35584 <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. --> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com> (cherry picked from commit 1739e2f)
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35694Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35694" |
github-actions
Bot
added
area-controls-radiobutton
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
This was referenced Jun 2, 2026
Open
This was referenced Jun 2, 2026
Contributor
Author
|
Failures are unrelated |
PureWeen
approved these changes
Jun 2, 2026
PureWeen
pushed a commit
that referenced
this pull request
Jun 8, 2026
Three improvements driven by SR8 dogfood: 1. New -InheritFromPriorSr flag for candidate mode. dotnet/maui's SR workflow is 'cut SRn+1 from main, then merge SRn into it' — so the SR-to-be contents = main-since-priorSR ∪ priorSR-only commits. The prior candidate model only saw main-since-priorSR, which made fixes that live only in SR7 look 'missing from SR8'. The new flag does a second 'git log priorSR ^main' pass and unions the source PRs, tagging each commit with origin = primary | inherited. Report header reads 'CANDIDATE for next SR (main + inherited from <prior>)' and the contents section splits into 'from main' vs 'inherited from <prior>'. 2. Skip Revert PRs as candidate fixes. If a 'Fixes #N' link points to a PR whose title starts with 'Revert ...', that PR is a rollback, not a fix — counting it as the fix produces false 'in-sr-active' verdicts when the actual fix has been backed out. When the only candidates are reverts the issue is classified needs-human-review with evidence 'All candidate fix PRs were Revert PRs — original fix may be missing or in a revert-of-revert chain.' This catches the #35584 / #35625 / #35694 chain cleanly. 3. Hard rule on the agent: report-only. The release-readiness agent and skill now declare in their first section that they NEVER mutate the dotnet/maui repo — no branch cuts, no SR merges, no tags, no pushes to release/* refs. If asked to perform a release operation, the agent refuses and surfaces copy-pasteable commands for the human release captain. Test coverage: 5 new tests cover the -InheritFromPriorSr happy path, the param-validation guard, the union semantics, and the well-known SR7-only backport (#35428) showing up via inheritance. All 26 tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 10, 2026
Closed
This was referenced Jun 14, 2026
Open
Open
PureWeen
pushed a commit
that referenced
this pull request
Jun 15, 2026
Three improvements driven by SR8 dogfood: 1. New -InheritFromPriorSr flag for candidate mode. dotnet/maui's SR workflow is 'cut SRn+1 from main, then merge SRn into it' — so the SR-to-be contents = main-since-priorSR ∪ priorSR-only commits. The prior candidate model only saw main-since-priorSR, which made fixes that live only in SR7 look 'missing from SR8'. The new flag does a second 'git log priorSR ^main' pass and unions the source PRs, tagging each commit with origin = primary | inherited. Report header reads 'CANDIDATE for next SR (main + inherited from <prior>)' and the contents section splits into 'from main' vs 'inherited from <prior>'. 2. Skip Revert PRs as candidate fixes. If a 'Fixes #N' link points to a PR whose title starts with 'Revert ...', that PR is a rollback, not a fix — counting it as the fix produces false 'in-sr-active' verdicts when the actual fix has been backed out. When the only candidates are reverts the issue is classified needs-human-review with evidence 'All candidate fix PRs were Revert PRs — original fix may be missing or in a revert-of-revert chain.' This catches the #35584 / #35625 / #35694 chain cleanly. 3. Hard rule on the agent: report-only. The release-readiness agent and skill now declare in their first section that they NEVER mutate the dotnet/maui repo — no branch cuts, no SR merges, no tags, no pushes to release/* refs. If asked to perform a release operation, the agent refuses and surfaces copy-pasteable commands for the human release captain. Test coverage: 5 new tests cover the -InheritFromPriorSr happy path, the param-validation guard, the union semantics, and the well-known SR7-only backport (#35428) showing up via inheritance. All 26 tests pass. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was referenced Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Backport of #35625 to
release/10.0.1xx-sr7./cc @PureWeen