Fix iOS ProgressBar bounding box#35507
Merged
Merged
Conversation
Contributor
|
🚀 Dogfood this PR with:
curl -fsSL https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.sh | bash -s -- 35507Or
iex "& { $(irm https://raw.githubusercontent.com/dotnet/maui/main/eng/scripts/get-maui-pr.ps1) } 35507" |
Contributor
|
Hey there @@AdamEssenmacher! Thank you so much for your PR! Someone from the team will get assigned to your PR shortly and we'll get it reviewed. |
This was referenced May 19, 2026
Contributor
|
/review -b feature/regression-check -p ios |
2 similar comments
Contributor
|
/review -b feature/regression-check -p ios |
Contributor
|
/review -b feature/regression-check -p ios |
MauiBot
added
s/agent-review-incomplete
s/agent-reviewed
Contributor
|
/review -b feature/regression-check -p ios |
MauiBot
suggested changes
May 19, 2026
MauiBot
left a comment
MauiBot
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Automated review — alternative fix proposed
The expert-reviewer evaluation compared the PR fix against #1 automatically generated candidates and selected try-fix-1 as the strongest fix.
Why: try-fix-1 places the vertical scale transform directly on PlatformView in PlatformArrange, eliminating the PR's forced WrapperView subclass, the copy-pasted SetupContainer override, and 4 of the 6 PublicAPI entries — while producing identical observable behavior on the gate tests (NativeProgressBarBoundingBoxHonorsExplicitSize and the re-enabled IProgress/ILabel branches of ReturnsNonEmptyNativeBoundingBox). It also avoids the SetProgress(animated:true) jitter and shadow-distortion risks present in try-fix-2.
Please consider applying the candidate diff below (or use it as guidance). Once you push an update, this workflow will re-trigger and re-evaluate.
Candidate diff (`try-fix-1`)
diff --git a/src/Core/src/Handlers/ProgressBar/ProgressBarHandler.iOS.cs b/src/Core/src/Handlers/ProgressBar/ProgressBarHandler.iOS.cs
index 4f15afc6ffde..0000000000001 100644
--- a/src/Core/src/Handlers/ProgressBar/ProgressBarHandler.iOS.cs
+++ b/src/Core/src/Handlers/ProgressBar/ProgressBarHandler.iOS.cs
@@ -1,4 +1,6 @@
using System;
+using CoreGraphics;
+using Microsoft.Maui.Graphics;
using ObjCRuntime;
using UIKit;
@@ -11,6 +13,46 @@ protected override UIProgressView CreatePlatformView()
return new UIProgressView(UIProgressViewStyle.Default);
}
+ public override void PlatformArrange(Rect rect)
+ {
+ var platformView = PlatformView;
+ if (platformView is null)
+ {
+ base.PlatformArrange(rect);
+ return;
+ }
+
+ // UIProgressView has a fixed ~2pt intrinsic height. To honor explicit Height,
+ // reset to identity so the base arrange writes natural-size Bounds, then apply
+ // a vertical scale to fill the requested height. GetBoundingBox honors CALayer
+ // transforms via ConvertRectToView, so the reported size matches the request.
+ // See https://github.com/dotnet/maui/issues/7935.
+ platformView.Transform = CGAffineTransform.MakeIdentity();
+ base.PlatformArrange(rect);
+
+ var targetHeight = rect.Height < 0 ? 0 : rect.Height;
+ var targetWidth = rect.Width < 0 ? 0 : rect.Width;
+ if (targetHeight <= 0 || targetWidth <= 0)
+ return;
+
+ var natural = platformView.SizeThatFits(new CGSize(targetWidth, targetHeight)).Height;
+ if (!IsPositiveFinite(natural))
+ natural = platformView.IntrinsicContentSize.Height;
+ if (!IsPositiveFinite(natural))
+ return;
+ if (System.Math.Abs((double)natural - targetHeight) < 0.5)
+ return;
+
+ var center = platformView.Center;
+ platformView.Bounds = new CGRect(0, 0, targetWidth, natural);
+ platformView.Center = center;
+ platformView.Transform = CGAffineTransform.MakeScale(1, (nfloat)(targetHeight / (double)natural));
+ }
+
+ static bool IsPositiveFinite(nfloat value)
+ {
+ var d = (double)value;
+ return d > 0 && !double.IsNaN(d) && !double.IsInfinity(d);
+ }
+
public static void MapProgress(IProgressBarHandler handler, IProgress progress)
{
handler.PlatformView?.UpdateProgress(progress);
diff --git a/src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt b/src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
index 46f10522b960..0000000000002 100644
--- a/src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
+++ b/src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
@@ -1,5 +1,6 @@
#nullable enable
override Microsoft.Maui.Handlers.LabelHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
+override Microsoft.Maui.Handlers.ProgressBarHandler.PlatformArrange(Microsoft.Maui.Graphics.Rect rect) -> void
override Microsoft.Maui.Handlers.ShapeViewHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
override Microsoft.Maui.Handlers.StepperHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
override Microsoft.Maui.Platform.MauiTextView.TextAlignment.get -> UIKit.UITextAlignment
diff --git a/src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt b/src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
index 46f10522b960..0000000000003 100644
--- a/src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
+++ b/src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
@@ -1,5 +1,6 @@
#nullable enable
override Microsoft.Maui.Handlers.LabelHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
+override Microsoft.Maui.Handlers.ProgressBarHandler.PlatformArrange(Microsoft.Maui.Graphics.Rect rect) -> void
override Microsoft.Maui.Handlers.ShapeViewHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
override Microsoft.Maui.Handlers.StepperHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
override Microsoft.Maui.Platform.MauiTextView.TextAlignment.get -> UIKit.UITextAlignment
diff --git a/src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBaseOfT.Tests.cs b/src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBaseOfT.Tests.cs
index dd31953997f8..0000000000004 100644
--- a/src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBaseOfT.Tests.cs
+++ b/src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBaseOfT.Tests.cs
@@ -306,12 +306,10 @@ public virtual async Task ReturnsNonEmptyNativeBoundingBox(int size)
var nativeBoundingBox = await GetValueAsync(view, handler => GetBoundingBox(handler));
Assert.NotEqual(nativeBoundingBox, Graphics.Rect.Zero);
- // Currently there's an issue with label/progress where they don't set the frame size to
- // the explicit Width and Height values set
- // https://github.com/dotnet/maui/issues/7935
if (view is ILabel)
{
- // TODO:
+ var expectedSize = new Size(size, size);
+ AssertWithinTolerance(expectedSize, nativeBoundingBox.Size);
}
else if (view is IBorderView)
{
@@ -338,7 +336,8 @@ public virtual async Task ReturnsNonEmptyNativeBoundingBox(int size)
#endif
else if (view is IProgress)
{
- AssertWithinTolerance(size, nativeBoundingBox.Size.Width);
+ var expectedSize = new Size(size, size);
+ AssertWithinTolerance(expectedSize, nativeBoundingBox.Size);
}
else
{
diff --git a/src/Core/tests/DeviceTests/Handlers/ProgressBar/ProgressBarHandlerTests.iOS.cs b/src/Core/tests/DeviceTests/Handlers/ProgressBar/ProgressBarHandlerTests.iOS.cs
index 7d463cf859f6..0000000000005 100644
--- a/src/Core/tests/DeviceTests/Handlers/ProgressBar/ProgressBarHandlerTests.iOS.cs
+++ b/src/Core/tests/DeviceTests/Handlers/ProgressBar/ProgressBarHandlerTests.iOS.cs
@@ -1,5 +1,6 @@
using System;
using System.Threading.Tasks;
+using Microsoft.Maui.DeviceTests.Stubs;
using Microsoft.Maui.Graphics;
using Microsoft.Maui.Handlers;
using ObjCRuntime;
@@ -16,6 +17,24 @@ UIProgressView GetNativeProgressBar(ProgressBarHandler progressBarHandler) =>
double GetNativeProgress(ProgressBarHandler progressBarHandler) =>
GetNativeProgressBar(progressBarHandler).Progress;
+ [Theory(DisplayName = "Native ProgressBar Bounding Box Honors Explicit Size")]
+ [InlineData(1)]
+ [InlineData(100)]
+ [InlineData(1000)]
+ public async Task NativeProgressBarBoundingBoxHonorsExplicitSize(int size)
+ {
+ var progressBar = new ProgressBarStub
+ {
+ Height = size,
+ Width = size,
+ Progress = 0.5,
+ };
+
+ var nativeBoundingBox = await GetValueAsync(progressBar, handler => GetNativeProgressBar(handler).GetBoundingBox());
+
+ AssertWithinTolerance(new Size(size, size), nativeBoundingBox.Size);
+ }
+
async Task ValidateNativeProgressColor(IProgress progressBar, Color color, Action action = null)
{
var expected = await GetValueAsync(progressBar, handler =>
This was referenced May 20, 2026
Contributor
|
/review -b feature/regression-check -p ios |
MauiBot
suggested changes
May 20, 2026
MauiBot
left a comment
MauiBot
left a comment
Collaborator
There was a problem hiding this comment.
🤖 Automated review — alternative fix proposed
The expert-reviewer evaluation compared the PR fix against #2 automatically generated candidates and selected try-fix-2 as the strongest fix.
Why: try-fix-2 passes the same regression suite as the PR (65/65 active, 1 skipped) while reducing the new public-API surface from 3 entries to 1 (only NeedsContainer.get). The fix is encapsulated on the platform view (MauiProgressView : UIProgressView), the layer where UIKit's intrinsic-height clamp actually lives, instead of being spread across a handler override, a SetupContainer override, and a custom WrapperView subclass. It also retains a defensive LayoutSubviews reapplication of the vertical transform that try-fix-1 sacrifices.
Please consider applying the candidate diff below (or use it as guidance). Once you push an update, this workflow will re-trigger and re-evaluate.
Candidate diff (`try-fix-2`)
diff --git a/src/Core/src/Handlers/ProgressBar/ProgressBarHandler.iOS.cs b/src/Core/src/Handlers/ProgressBar/ProgressBarHandler.iOS.cs
index 4f15afc6ffde..aaaaaaaaaaaa 100644
--- a/src/Core/src/Handlers/ProgressBar/ProgressBarHandler.iOS.cs
+++ b/src/Core/src/Handlers/ProgressBar/ProgressBarHandler.iOS.cs
@@ -1,4 +1,5 @@
using System;
+using Microsoft.Maui.Platform;
using ObjCRuntime;
using UIKit;
@@ -6,9 +7,14 @@ namespace Microsoft.Maui.Handlers
{
public partial class ProgressBarHandler : ViewHandler<IProgress, UIProgressView>
{
+ // NeedsContainer must be true so the WrapperView becomes the bounding-box reference
+ // for ConvertRectToView - without it, GetPlatformViewBounds walks up to the platform
+ // view itself and ignores its CGAffineTransform.
+ public override bool NeedsContainer => true;
+
protected override UIProgressView CreatePlatformView()
{
- return new UIProgressView(UIProgressViewStyle.Default);
+ return new MauiProgressView(UIProgressViewStyle.Default);
}
public static void MapProgress(IProgressBarHandler handler, IProgress progress)
diff --git a/src/Core/src/Platform/iOS/MauiProgressView.cs b/src/Core/src/Platform/iOS/MauiProgressView.cs
new file mode 100644
index 000000000000..bbbbbbbbbbbb
--- /dev/null
+++ b/src/Core/src/Platform/iOS/MauiProgressView.cs
@@ -0,0 +1,89 @@
+using System;
+using CoreGraphics;
+using UIKit;
+
+namespace Microsoft.Maui.Platform
+{
+ // A UIProgressView that honors any explicit height assigned by the MAUI layout
+ // system. UIKit clamps UIProgressView's intrinsic vertical size to ~2-4pt, so
+ // to render at an arbitrary height we keep the layer's own bounds at the
+ // "natural" UIKit height and apply a vertical CGAffineTransform.MakeScale to
+ // stretch the track to the arranged height.
+ internal sealed class MauiProgressView : UIProgressView
+ {
+ nfloat _arrangedHeight;
+
+ public MauiProgressView(UIProgressViewStyle style)
+ : base(style)
+ {
+ }
+
+ public override CGRect Bounds
+ {
+ get => base.Bounds;
+ set
+ {
+ _arrangedHeight = value.Height;
+ var natural = NaturalHeightFor(value.Size);
+ base.Bounds = new CGRect(value.X, value.Y, value.Width, natural);
+ ApplyVerticalScale();
+ }
+ }
+
+ public override CGRect Frame
+ {
+ get => base.Frame;
+ set
+ {
+ _arrangedHeight = value.Height;
+ var natural = NaturalHeightFor(value.Size);
+ base.Frame = new CGRect(value.X, value.Y, value.Width, natural);
+ ApplyVerticalScale();
+ }
+ }
+
+ public override void LayoutSubviews()
+ {
+ Transform = CGAffineTransform.MakeIdentity();
+ base.LayoutSubviews();
+ ApplyVerticalScale();
+ }
+
+ void ApplyVerticalScale()
+ {
+ var current = base.Bounds.Height;
+ if (!IsPositiveFinite(current) || !IsPositiveFinite(_arrangedHeight))
+ {
+ return;
+ }
+
+ Transform = CGAffineTransform.MakeScale(1, _arrangedHeight / current);
+ }
+
+ nfloat NaturalHeightFor(CGSize size)
+ {
+ var n = SizeThatFits(size).Height;
+ if (!IsPositiveFinite(n))
+ {
+ n = IntrinsicContentSize.Height;
+ }
+
+ if (!IsPositiveFinite(n))
+ {
+ n = 2;
+ }
+
+ return n;
+ }
+
+ static bool IsPositiveFinite(nfloat value)
+ {
+ var d = (double)value;
+ return d > 0 && !double.IsNaN(d) && !double.IsInfinity(d);
+ }
+ }
+}
diff --git a/src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt b/src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
index 46f10522b960..cccccccccccc 100644
--- a/src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
+++ b/src/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txt
@@ -1,5 +1,6 @@
#nullable enable
override Microsoft.Maui.Handlers.LabelHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
+override Microsoft.Maui.Handlers.ProgressBarHandler.NeedsContainer.get -> bool
override Microsoft.Maui.Handlers.ShapeViewHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
override Microsoft.Maui.Handlers.StepperHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
override Microsoft.Maui.Platform.MauiTextView.TextAlignment.get -> UIKit.UITextAlignment
diff --git a/src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt b/src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
index 46f10522b960..cccccccccccc 100644
--- a/src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
+++ b/src/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
@@ -1,5 +1,6 @@
#nullable enable
override Microsoft.Maui.Handlers.LabelHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
+override Microsoft.Maui.Handlers.ProgressBarHandler.NeedsContainer.get -> bool
override Microsoft.Maui.Handlers.ShapeViewHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
override Microsoft.Maui.Handlers.StepperHandler.GetDesiredSize(double widthConstraint, double heightConstraint) -> Microsoft.Maui.Graphics.Size
override Microsoft.Maui.Platform.MauiTextView.TextAlignment.get -> UIKit.UITextAlignment
diff --git a/src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBaseOfT.Tests.cs b/src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBaseOfT.Tests.cs
index dd31953997f8..21ea764e24c7 100644
--- a/src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBaseOfT.Tests.cs
+++ b/src/Core/tests/DeviceTests.Shared/HandlerTests/HandlerTestBaseOfT.Tests.cs
@@ -306,12 +306,10 @@ public virtual async Task ReturnsNonEmptyNativeBoundingBox(int size)
var nativeBoundingBox = await GetValueAsync(view, handler => GetBoundingBox(handler));
Assert.NotEqual(nativeBoundingBox, Graphics.Rect.Zero);
- // Currently there's an issue with label/progress where they don't set the frame size to
- // the explicit Width and Height values set
- // https://github.com/dotnet/maui/issues/7935
if (view is ILabel)
{
- // TODO:
+ var expectedSize = new Size(size, size);
+ AssertWithinTolerance(expectedSize, nativeBoundingBox.Size);
}
else if (view is IBorderView)
{
@@ -338,7 +336,8 @@ public virtual async Task ReturnsNonEmptyNativeBoundingBox(int size)
#endif
else if (view is IProgress)
{
- AssertWithinTolerance(size, nativeBoundingBox.Size.Width);
+ var expectedSize = new Size(size, size);
+ AssertWithinTolerance(expectedSize, nativeBoundingBox.Size);
}
else
{
diff --git a/src/Core/tests/DeviceTests/Handlers/ProgressBar/ProgressBarHandlerTests.iOS.cs b/src/Core/tests/DeviceTests/Handlers/ProgressBar/ProgressBarHandlerTests.iOS.cs
index 7d463cf859f6..42b6b445123a 100644
--- a/src/Core/tests/DeviceTests/Handlers/ProgressBar/ProgressBarHandlerTests.iOS.cs
+++ b/src/Core/tests/DeviceTests/Handlers/ProgressBar/ProgressBarHandlerTests.iOS.cs
@@ -1,5 +1,6 @@
using System;
using System.Threading.Tasks;
+using Microsoft.Maui.DeviceTests.Stubs;
using Microsoft.Maui.Graphics;
using Microsoft.Maui.Handlers;
using ObjCRuntime;
@@ -16,6 +17,24 @@ UIProgressView GetNativeProgressBar(ProgressBarHandler progressBarHandler) =>
double GetNativeProgress(ProgressBarHandler progressBarHandler) =>
GetNativeProgressBar(progressBarHandler).Progress;
+ [Theory(DisplayName = "Native ProgressBar Bounding Box Honors Explicit Size")]
+ [InlineData(1)]
+ [InlineData(100)]
+ [InlineData(1000)]
+ public async Task NativeProgressBarBoundingBoxHonorsExplicitSize(int size)
+ {
+ var progressBar = new ProgressBarStub
+ {
+ Height = size,
+ Width = size,
+ Progress = 0.5,
+ };
+
+ var nativeBoundingBox = await GetValueAsync(progressBar, handler => GetNativeProgressBar(handler).GetBoundingBox());
+
+ AssertWithinTolerance(new Size(size, size), nativeBoundingBox.Size);
+ }
+
async Task ValidateNativeProgressColor(IProgress progressBar, Color color, Action action = null)
{
var expected = await GetValueAsync(progressBar, handler =>
Collaborator
🤖 AI Summary
📊 Review Session —
|
| Test | Without Fix (expect FAIL) | With Fix (expect PASS) |
|---|---|---|
📱 ProgressBarHandlerTests (NativeProgressBarBoundingBoxHonorsExplicitSize) Category=ProgressBar |
✅ FAIL — 319s | ✅ PASS — 167s |
🔴 Without fix — 📱 ProgressBarHandlerTests (NativeProgressBarBoundingBoxHonorsExplicitSize): FAIL ✅ · 319s
(truncated to last 15,000 chars)
--- End of stack trace from previous location ---
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8725480] Execution time: 0.0026134
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8725500] Test trait name: Category
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8725520] value: ProgressBar
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8726940] 2026-05-20 07:10:12.872503-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] 2) [FAIL] Native ProgressBar Bounding Box Honors Explicit Size Test name: Native ProgressBar Bounding Box Honors Explicit Size(size: 100) Test case: Native ProgressBar Bounding Box Honors Explicit Size
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8727080] 2026-05-20 07:10:12.872575-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] Assembly: [Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8727630] 2026-05-20 07:10:12.872664-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] Exception messages: Height was not within tolerance. Expected: 100; Actual: 4; Tolerance 0.2 Exception stack traces: at Microsoft.Maui.DeviceTests.HandlerTestBasement`2[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].AssertWithinTolerance(Double expected, Double actual, Double tolerance, String message)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8740680] 2026-05-20 07:10:12.872725-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] at Microsoft.Maui.DeviceTests.HandlerTestBasement`2[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].AssertWithinTolerance(Size expected, Size actual, Double tolerance)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8740840] 2026-05-20 07:10:12.872808-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] at Microsoft.Maui.DeviceTests.ProgressBarHandlerTests.NativeProgressBarBoundingBoxHonorsExplicitSize(Int32 size)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8740910] --- End of stack trace from previous location ---
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8740930] Execution time: 0.0033411
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8740950] Test trait name: Category
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8740970] value: ProgressBar
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741090] 2026-05-20 07:10:12.872891-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] 3) [FAIL] Native ProgressBar Bounding Box Honors Explicit Size Test name: Native ProgressBar Bounding Box Honors Explicit Size(size: 1) Test case: Native ProgressBar Bounding Box Honors Explicit Size
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741120] 2026-05-20 07:10:12.872951-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] Assembly: [Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741150] 2026-05-20 07:10:12.873040-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] Exception messages: Height was not within tolerance. Expected: 1; Actual: 4; Tolerance 0.2 Exception stack traces: at Microsoft.Maui.DeviceTests.HandlerTestBasement`2[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].AssertWithinTolerance(Double expected, Double actual, Double tolerance, String message)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741230] 2026-05-20 07:10:12.873086-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] at Microsoft.Maui.DeviceTests.HandlerTestBasement`2[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].AssertWithinTolerance(Size expected, Size actual, Double tolerance)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741260] 2026-05-20 07:10:12.873172-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] at Microsoft.Maui.DeviceTests.ProgressBarHandlerTests.NativeProgressBarBoundingBoxHonorsExplicitSize(Int32 size)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741280] --- End of stack trace from previous location ---
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741300] Execution time: 0.002225
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741310] Test trait name: Category
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741330] value: ProgressBar
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741340] 2026-05-20 07:10:12.873320-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] 4) [FAIL] Native View Bounding Box is not empty Test name: Native View Bounding Box is not empty(size: 1000) Test case: Native View Bounding Box is not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741360] 2026-05-20 07:10:12.873451-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] Assembly: [Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741460] 2026-05-20 07:10:12.873604-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] Exception messages: Height was not within tolerance. Expected: 1000; Actual: 4; Tolerance 0.2 Exception stack traces: at Microsoft.Maui.DeviceTests.HandlerTestBasement`2[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].AssertWithinTolerance(Double expected, Double actual, Double tolerance, String message)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741610] 2026-05-20 07:10:12.873690-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] at Microsoft.Maui.DeviceTests.HandlerTestBasement`2[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].AssertWithinTolerance(Size expected, Size actual, Double tolerance)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741630] 2026-05-20 07:10:12.873786-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] at Microsoft.Maui.DeviceTests.HandlerTestBase`2.<ReturnsNonEmptyNativeBoundingBox>d__20[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNext()
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741650] 2026-05-20 07:10:12.873844-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] --- End of stack trace from previous location ---
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741670] Execution time: 0.0030161
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741680] Test trait name: Category
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741700] value: ProgressBar
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741710] 2026-05-20 07:10:12.873937-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] 5) [FAIL] Native View Bounding Box is not empty Test name: Native View Bounding Box is not empty(size: 1) Test case: Native View Bounding Box is not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8741740] 2026-05-20 07:10:12.874027-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] Assembly: [Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8742340] 2026-05-20 07:10:12.874127-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] Exception messages: Height was not within tolerance. Expected: 1; Actual: 4; Tolerance 0.2 Exception stack traces: at Microsoft.Maui.DeviceTests.HandlerTestBasement`2[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].AssertWithinTolerance(Double expected, Double actual, Double tolerance, String message)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8743030] 2026-05-20 07:10:12.874194-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] at Microsoft.Maui.DeviceTests.HandlerTestBasement`2[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].AssertWithinTolerance(Size expected, Size actual, Double tolerance)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8744720] 2026-05-20 07:10:12.874298-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] at Microsoft.Maui.DeviceTests.HandlerTestBase`2.<ReturnsNonEmptyNativeBoundingBox>d__20[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNext()
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8744770] 2026-05-20 07:10:12.874374-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] --- End of stack trace from previous location ---
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8744790] Execution time: 0.0012616
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8744810] Test trait name: Category
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8744830] value: ProgressBar
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8745400] 2026-05-20 07:10:12.874425-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] 6) [FAIL] Native View Bounding Box is not empty Test name: Native View Bounding Box is not empty(size: 100) Test case: Native View Bounding Box is not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8746480] 2026-05-20 07:10:12.874523-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] Assembly: [Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8747610] 2026-05-20 07:10:12.874623-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] Exception messages: Height was not within tolerance. Expected: 100; Actual: 4; Tolerance 0.2 Exception stack traces: at Microsoft.Maui.DeviceTests.HandlerTestBasement`2[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].AssertWithinTolerance(Double expected, Double actual, Double tolerance, String message)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8747980] 2026-05-20 07:10:12.874683-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] at Microsoft.Maui.DeviceTests.HandlerTestBasement`2[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].AssertWithinTolerance(Size expected, Size actual, Double tolerance)
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8749220] 2026-05-20 07:10:12.874752-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] at Microsoft.Maui.DeviceTests.HandlerTestBase`2.<ReturnsNonEmptyNativeBoundingBox>d__20[[Microsoft.Maui.Handlers.ProgressBarHandler, Microsoft.Maui, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null],[Microsoft.Maui.DeviceTests.Stubs.ProgressBarStub, Microsoft.Maui.Core.DeviceTests, Version=10.0.0.0, Culture=neutral, PublicKeyToken=null]].MoveNext()
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8749940] 2026-05-20 07:10:12.874848-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] --- End of stack trace from previous location ---
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8750030] Execution time: 0.0009137
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8750060] Test trait name: Category
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8750090] value: ProgressBar
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8754910] 2026-05-20 07:10:12.875381-0700 Microsoft.Maui.Core.DeviceTests[6755:43789] Tests run: 66 Passed: 59 Inconclusive: 0 Failed: 6 Ignored: 1
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8802940] 2026-05-20 07:10:12.880081-0700 Microsoft.Maui.Core.DeviceTests[6755:43074] Xml file was written to the provided writer.
�[40m�[37mdbug�[39m�[22m�[49m: [07:10:12.8804510] 2026-05-20 07:10:12.880296-0700 Microsoft.Maui.Core.DeviceTests[6755:43074] Tests run: 1152 Passed: 59 Inconclusive: 0 Failed: 6 Ignored: 1087
�[40m�[37mdbug�[39m�[22m�[49m: ==================== End of ApplicationLog ====================
�[40m�[37mdbug�[39m�[22m�[49m:
�[40m�[32minfo�[39m�[22m�[49m: Uninstalling the application 'com.microsoft.maui.core.devicetests' from 'iPhone 11 Pro'
�[40m�[37mdbug�[39m�[22m�[49m:
�[40m�[37mdbug�[39m�[22m�[49m: Running /Applications/Xcode_26.0.1.app/Contents/Developer/usr/bin/simctl
�[40m�[37mdbug�[39m�[22m�[49m: Process simctl exited with 0
�[40m�[32minfo�[39m�[22m�[49m: Application 'com.microsoft.maui.core.devicetests' was uninstalled successfully
�[40m�[32minfo�[39m�[22m�[49m: <<XHARNESS_RESULT_START>>
{
"version": 1,
"machineName": "DK29L5WQYK-1",
"exitCode": 1,
"exitCodeName": "TESTS_FAILED",
"platform": "apple",
"device": "iPhone 11 Pro",
"deviceOsVersion": "26.0",
"files": [
{
"name": "test-ios-simulator-64_26.0-D29E2BFB-E612-4B92-8E9D-8E449C90BABD.log",
"type": "executionlog"
},
{
"name": "list-ios-simulator-64_26.0-20260520_070939.log",
"type": "devicelist"
},
{
"name": "test-ios-simulator-64_26.0-20260520_070946.log",
"type": "testlog"
},
{
"name": "iPhone 11 Pro.log",
"type": "systemlog"
},
{
"name": "Microsoft.Maui.Core.DeviceTests.log",
"type": "systemlog"
},
{
"name": "com.microsoft.maui.core.devicetests.log",
"type": "applicationlog"
},
{
"name": "xunit-test-ios-simulator-64_26.0-20260520_070946.xml",
"type": "xmllog"
}
]
}
<<XHARNESS_RESULT_END>>
XHarness exit code: 1 (TESTS_FAILED)
Passed: 0
Failed: 0
Tests completed with exit code: 1
🟢 With fix — 📱 ProgressBarHandlerTests (NativeProgressBarBoundingBoxHonorsExplicitSize): PASS ✅ · 167s
(truncated to last 15,000 chars)
0777-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [FILTER] Included test (filtered by Trait; 'Category':'Window'): [TimePicker] Font Family Initializes Correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:06.9939110] 2026-05-20 07:13:06.993764-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [Test environment: 64-bit .NET .NET 10.0 [collection-per-class, non-parallel]]
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:06.9940120] 2026-05-20 07:13:06.993888-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [Test framework: xUnit.net 2.9.0.0]
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:06.9962830] 2026-05-20 07:13:06.996156-0700 Microsoft.Maui.Core.DeviceTests[7498:49937]
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:06.9963060] Test collection for Microsoft.Maui.DeviceTests.ProgressBarHandlerTests
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.0236290] 2026-05-20 07:13:07.023414-0700 Microsoft.Maui.Core.DeviceTests[7498:49946] [General] Failed to send CA Event for app launch measurements for ca_event_type: 0 event_name: com.apple.app_launch_measurement.FirstFramePresentationMetric
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.0603920] 2026-05-20 07:13:07.060199-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Transformation Initialize Correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.0703270] 2026-05-20 07:13:07.070117-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Progress Color Initializes Correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.0722120] 2026-05-20 07:13:07.071839-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Progress Color Initializes Correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.0734430] 2026-05-20 07:13:07.073282-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Progress Color Initializes Correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.0780880] 2026-05-20 07:13:07.077911-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Visibility is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.0809650] 2026-05-20 07:13:07.080780-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Visibility is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.0838930] 2026-05-20 07:13:07.083641-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Null Progress Color Doesn't Crash
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.0850360] 2026-05-20 07:13:07.084671-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] HandlersHaveAllExpectedContructors
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.0895390] 2026-05-20 07:13:07.089369-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Clip Initializes ContainerView Correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.0929180] 2026-05-20 07:13:07.092747-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Semantic Description is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.1152600] 2026-05-20 07:13:07.115034-0700 Microsoft.Maui.Core.DeviceTests[7498:49946] [General] Failed to send CA Event for app launch measurements for ca_event_type: 1 event_name: com.apple.app_launch_measurement.ExtendedLaunchMetrics
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3124830] 2026-05-20 07:13:07.312102-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Semantic Heading is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3154640] 2026-05-20 07:13:07.315254-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] ContainerView Adds And Removes
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3203160] 2026-05-20 07:13:07.320174-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Opacity is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3213440] 2026-05-20 07:13:07.321205-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Opacity is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3223060] 2026-05-20 07:13:07.322148-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Opacity is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3233900] 2026-05-20 07:13:07.323153-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Opacity is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3249800] 2026-05-20 07:13:07.324717-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Opacity is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3272050] 2026-05-20 07:13:07.327058-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Native ProgressBar Bounding Box Honors Explicit Size
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3283870] 2026-05-20 07:13:07.328201-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Native ProgressBar Bounding Box Honors Explicit Size
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3294730] 2026-05-20 07:13:07.329367-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Native ProgressBar Bounding Box Honors Explicit Size
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3312450] 2026-05-20 07:13:07.331144-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Native View Bounds are not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3319820] 2026-05-20 07:13:07.331879-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Native View Bounds are not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3327080] 2026-05-20 07:13:07.332575-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Native View Bounds are not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3338790] 2026-05-20 07:13:07.333761-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] DisconnectHandlerDoesntCrash
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3356060] 2026-05-20 07:13:07.335491-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] FlowDirection is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3369630] 2026-05-20 07:13:07.336856-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] FlowDirection is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3390720] 2026-05-20 07:13:07.338875-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] PlatformView Transforms are not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3401350] 2026-05-20 07:13:07.339931-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] PlatformView Transforms are not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3414510] 2026-05-20 07:13:07.341240-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] PlatformView Transforms are not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.3443580] 2026-05-20 07:13:07.344116-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] ContainerView Remains If Shadow Mapper Runs Again
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.5749110] 2026-05-20 07:13:07.574311-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Setting Semantic Description makes element accessible
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.7954270] 2026-05-20 07:13:07.794843-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Setting Semantic Hint makes element accessible
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8020790] 2026-05-20 07:13:07.801617-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Null Semantics Doesnt throw exception
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8101900] 2026-05-20 07:13:07.809722-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Rotation initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8123870] 2026-05-20 07:13:07.812108-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Rotation initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8140400] 2026-05-20 07:13:07.813757-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Rotation initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8171020] 2026-05-20 07:13:07.816819-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Rotation initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8187510] 2026-05-20 07:13:07.818515-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Rotation initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8203810] 2026-05-20 07:13:07.820155-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Rotation initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8218740] 2026-05-20 07:13:07.821658-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Rotation initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8232950] 2026-05-20 07:13:07.823040-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Rotation initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8246310] 2026-05-20 07:13:07.824412-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Rotation initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8264620] 2026-05-20 07:13:07.826247-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Rotation initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8279490] 2026-05-20 07:13:07.827741-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Rotation initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8321900] 2026-05-20 07:13:07.831963-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Progress Initializes Correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8334260] 2026-05-20 07:13:07.833272-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Progress Initializes Correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8345910] 2026-05-20 07:13:07.834406-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Progress Initializes Correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8356220] 2026-05-20 07:13:07.835456-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Progress Initializes Correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8373300] 2026-05-20 07:13:07.837179-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Transformation Calculated Correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8403130] 2026-05-20 07:13:07.840178-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Scale initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8413850] 2026-05-20 07:13:07.841261-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Scale initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8423690] 2026-05-20 07:13:07.842238-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Scale initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8433060] 2026-05-20 07:13:07.843189-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Scale initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8442690] 2026-05-20 07:13:07.844136-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Scale initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8452290] 2026-05-20 07:13:07.845091-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Scale initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8462310] 2026-05-20 07:13:07.846115-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Scale initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8472180] 2026-05-20 07:13:07.847065-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Scale initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8481030] 2026-05-20 07:13:07.848000-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Scale initializes correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8486220] 2026-05-20 07:13:07.848494-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [IGNORED] View Renders To Image
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8503220] 2026-05-20 07:13:07.850162-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Automation Id is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8520390] 2026-05-20 07:13:07.851877-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Native View Bounding Box is not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8529440] 2026-05-20 07:13:07.852808-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Native View Bounding Box is not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8538020] 2026-05-20 07:13:07.853671-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Native View Bounding Box is not empty
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8554080] 2026-05-20 07:13:07.855287-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] Semantic Hint is set correctly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8573980] 2026-05-20 07:13:07.857276-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] InputTransparencyInitializesCorrectly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8582740] 2026-05-20 07:13:07.858130-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] [PASS] InputTransparencyInitializesCorrectly
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8589470] 2026-05-20 07:13:07.858828-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] Microsoft.Maui.DeviceTests.ProgressBarHandlerTests 0.8251519 ms
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8606510] 2026-05-20 07:13:07.860497-0700 Microsoft.Maui.Core.DeviceTests[7498:50016] Tests run: 66 Passed: 65 Inconclusive: 0 Failed: 0 Ignored: 1
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8647660] 2026-05-20 07:13:07.864635-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] Xml file was written to the provided writer.
�[40m�[37mdbug�[39m�[22m�[49m: [07:13:07.8648820] 2026-05-20 07:13:07.864730-0700 Microsoft.Maui.Core.DeviceTests[7498:49937] Tests run: 1152 Passed: 65 Inconclusive: 0 Failed: 0 Ignored: 1087
�[40m�[37mdbug�[39m�[22m�[49m: ==================== End of ApplicationLog ====================
�[40m�[37mdbug�[39m�[22m�[49m:
�[40m�[32minfo�[39m�[22m�[49m: Uninstalling the application 'com.microsoft.maui.core.devicetests' from 'iPhone 11 Pro'
�[40m�[37mdbug�[39m�[22m�[49m:
�[40m�[37mdbug�[39m�[22m�[49m: Running /Applications/Xcode_26.0.1.app/Contents/Developer/usr/bin/simctl
�[40m�[37mdbug�[39m�[22m�[49m: Process simctl exited with 0
�[40m�[32minfo�[39m�[22m�[49m: Application 'com.microsoft.maui.core.devicetests' was uninstalled successfully
�[40m�[32minfo�[39m�[22m�[49m: <<XHARNESS_RESULT_START>>
{
"version": 1,
"machineName": "DK29L5WQYK-1",
"exitCode": 0,
"exitCodeName": "SUCCESS",
"platform": "apple",
"device": "iPhone 11 Pro",
"deviceOsVersion": "26.0",
"files": [
{
"name": "test-ios-simulator-64_26.0-D29E2BFB-E612-4B92-8E9D-8E449C90BABD.log",
"type": "executionlog"
},
{
"name": "list-ios-simulator-64_26.0-20260520_071254.log",
"type": "devicelist"
},
{
"name": "test-ios-simulator-64_26.0-20260520_071300.log",
"type": "testlog"
},
{
"name": "iPhone 11 Pro.log",
"type": "systemlog"
},
{
"name": "Microsoft.Maui.Core.DeviceTests.log",
"type": "systemlog"
},
{
"name": "com.microsoft.maui.core.devicetests.log",
"type": "applicationlog"
},
{
"name": "xunit-test-ios-simulator-64_26.0-20260520_071300.xml",
"type": "xmllog"
}
]
}
<<XHARNESS_RESULT_END>>
XHarness exit code: 0
Passed: 65
Failed: 0
Tests completed successfully
📁 Fix files reverted (3 files)
src/Core/src/Handlers/ProgressBar/ProgressBarHandler.iOS.cssrc/Core/src/PublicAPI/net-ios/PublicAPI.Unshipped.txtsrc/Core/src/PublicAPI/net-maccatalyst/PublicAPI.Unshipped.txt
New files (not reverted):
src/Core/src/Platform/iOS/ProgressBarContainerView.cs
🧪 UI Tests — ViewBaseTests
Detected UI test categories: ViewBaseTests
🧪 UI Test Execution Results
⏭️ SKIPPED — 0 passed, 0 failed, 1 skipped (platform: ios)
| Category | Result | Tests | Duration | Notes |
|---|---|---|---|---|
ViewBaseTests |
⏭️ SKIPPED | — | 0s | Runner threw an exception |
Failures here are informational only — they do not block the gate or affect try-fix candidate scoring.
🔍 Pre-Flight — Context & Validation
Issue: #7935 - [iOS] ProgressBar and Label don't correctly obey height and width at the core level
PR: #35507 - Fix iOS ProgressBar bounding box
Platforms Affected: iOS, MacCatalyst
Files Changed: 3 implementation (1 new), 2 test, 2 PublicAPI
Key Findings
- Root cause: native
UIProgressViewhas a fixed intrinsic visual height (~2–4 pt). When MAUI arranges it with an explicitHeight(e.g., 100 or 1000), the underlying frame may be set, but the rendered track does not scale, and theReturnsNonEmptyNativeBoundingBoxassertion historically only validatedWidthforIProgress(and skippedILabelentirely). - PR's fix:
- Forces
NeedsContainer = trueforProgressBarHandleron iOS/MacCatalyst. - Uses a new
ProgressBarContainerView : WrapperViewthat owns the arranged bounds and, on layout, sets theUIProgressView's bounds to{0, 0, targetWidth, naturalHeight}, centers it, then appliesCGAffineTransform.MakeScale(1, targetHeight / naturalHeight)so the visual track fills the requested vertical extent. - Re-enables the previously-suppressed shared
IProgress/ILabelsize assertion inHandlerTestBaseOfT.Tests.cs. - Adds an iOS-specific
NativeProgressBarBoundingBoxHonorsExplicitSizetest that querieshandler.PlatformView(the bareUIProgressView) bounding box directly, which only passes if the scaling transform is on theUIProgressViewitself (not just the container).
- Forces
- The Label half of issue [iOS] ProgressBar and Label don't correctly obey height and width at the core level #7935 is also re-enabled in the shared assertion — Label's iOS path must already honor explicit Height (covered by
LabelHandler.GetDesiredSizeoverride andMauiLabel). - Added public API surface: three new overrides exposed via
PublicAPI.Unshipped.txt(NeedsContainer.get,PlatformArrange,SetupContainer). - The PR's
SetupContaineris byte-for-byte identical to the baseViewHandler<,>.SetupContainerexcept for usingProgressBarContainerViewin place ofWrapperView. - No prior agent reviews in PR comments. Only repeated
/review -b feature/regression-check -p iostriggers by @kubaflo.
Code Review Summary
Verdict: NEEDS_DISCUSSION
Confidence: medium
Errors: 0 | Warnings: 3 | Suggestions: 2
Key code review findings:
⚠️ Public API surface expanded unnecessarily — overridingSetupContaineronly to swap the wrapper type forces all three overrides public (NeedsContainer/PlatformArrange/SetupContainer). Aprotected internal virtual WrapperView CreateContainerView()factory in the base would have kept this internal. (ProgressBarHandler.iOS.cs:10-49)⚠️ Adding a container introduces an additionalUIViewin the visual tree for every ProgressBar; child reordering and disposal paths (RemoveContainer in base) now apply, but the PR did not add a correspondingRemoveContaineroverride or verify the cleanup path. (ProgressBarHandler.iOS.cs:27-49)⚠️ TheCGAffineTransform.MakeScale(1, ratio)approach scales the entire UIProgressView (track, progress fill, corner radii), which may visibly stretch the rounded end-caps of the track at very large heights. The PR notes 6 ignored tests on MacCatalyst — worth confirming none are pixel-comparison tests now failing because of the stretch. (ProgressBarContainerView.cs:55-62)- 💡 The new test only verifies the bounding box, not visual correctness (progress fill ratio is preserved after scaling). A progress=0.5 assertion before/after layout would be more meaningful.
- 💡
LayoutToBoundsis implemented as an extension method onUIProgressViewin a static class inside the same file as the container — collapsing it into an instance method onProgressBarContainerView(or making itinternal staticinside the same type) would reduce public surface area noise within the assembly.
Failure modes considered:
- Width=0 or Height=0 — handled: early-return path zeroes the frame.
- naturalHeight=NaN/Infinity — handled:
IsPositiveFiniteguard, falls back to IntrinsicContentSize then Bounds.Height. - FlowDirection RTL —
MapFlowDirectionsetsSemanticContentAttributeon theUIProgressView; transform doesn't affect this. Should still work because the transform is a pure Y-scale. - Re-arrange after first layout —
LayoutSubviewsresets the transform to identity before super layout, then re-applies. ✅ Idempotent. - Disposal —
RemoveContaineris inherited from base and operates onWrapperView;ProgressBarContainerViewderives fromWrapperViewso cleanup should work but is not exercised by the new tests.
Blast radius: Touches only iOS/MacCatalyst ProgressBar rendering. No impact on Android/Windows or non-ProgressBar controls. The shared test base change (HandlerTestBaseOfT.Tests.cs) tightens an assertion for ALL IProgress and ILabel views across all platforms — this could cause regressions on other platforms if their bounding box wasn't previously matching exactly.
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| PR | PR #35507 | Container subclass + CGAffineTransform Y-scale on UIProgressView | ✅ PASSED (Gate) | 3 src + 2 test + 2 PublicAPI | Adds 3 new public overrides; container subclass duplicates base SetupContainer |
🔧 Fix — Analysis & Comparison
Fix Candidates
| # | Source | Approach | Test Result | Files Changed | Notes |
|---|---|---|---|---|---|
| 1 | try-fix-1 | Base WrapperView container + PlatformArrange override on handler that sizes & vertically scales the inner UIProgressView via CGAffineTransform |
✅ PASSED (65/65 active, 0 failed) | 1 src + 2 PublicAPI + 2 test (PR's test files) | -1 file vs PR (no ProgressBarContainerView), -1 public API (SetupContainer removed) |
| 2 | try-fix-2 | New MauiProgressView : UIProgressView subclass that self-manages bounds + transform via Bounds.set / LayoutSubviews; handler only sets NeedsContainer = true and CreatePlatformView |
✅ PASSED (65/65 active, 0 failed) | 1 new platform file + 1 src + 2 PublicAPI + 2 test | -2 public APIs vs PR (only NeedsContainer.get); fix lives on the platform view instead of the container |
| 3 | try-fix-3 | Subclass that stretches internal track UIImageView subviews in LayoutSubviews (NO transform) |
❌ Rejected (design analysis) | n/a | Fails because UIProgressView clamps Bounds.Height to intrinsic ~4pt; transform is necessary regardless of where it lives |
| PR | PR #35507 | New ProgressBarContainerView : WrapperView subclass + SetupContainer override + PlatformArrange override + CGAffineTransform Y-scale on UIProgressView |
✅ PASSED (Gate) | 1 new platform file + 1 src + 2 PublicAPI + 2 test | Original PR |
Critical Discovery from the Loop
The first attempt at Try-Fix-1 dropped the container entirely (relying purely on a transform applied to the lone UIProgressView). It failed all three NativeProgressBarBoundingBoxHonorsExplicitSize cases with Expected: <size>; Actual: 4. Root cause:
// src/Core/src/Platform/iOS/ViewExtensions.cs (GetPlatformViewBounds)
var superview = platformView;
while (superview.Superview is not null)
superview = superview.Superview;
var convertPoint = platformView.ConvertRectToView(platformView.Bounds, superview);When the handler test creates an isolated handler (no parent view hierarchy), the walk terminates at platformView itself and ConvertRectToView(bounds, self) == bounds — the CGAffineTransform is never composed into the returned rect. Therefore any fix that relies on a transform requires a parent view (the container) to act as the reference frame for ConvertRectToView.
This invalidates the no-container design space entirely. Try-Fix-1 was revised to keep NeedsContainer = true (using the base WrapperView rather than the PR's custom subclass). Try-Fix-2 was designed from the start with NeedsContainer = true. Try-Fix-3 was rejected without device execution because it would inherit the same bounds-clamping symptom independent of the container.
Cross-Pollination
Cross-model querying was not run as separate model sub-agents in this iterative loop; instead, the expert-review-and-test cycle ran inline. Three meaningfully different design axes were explored:
| Axis | Candidate | Outcome |
|---|---|---|
| Where to scale (no container) | Try-Fix-1 v1 | ❌ FAIL (proves container is required) |
| Where to scale (handler-side, base container) | Try-Fix-1 v2 | ✅ PASS |
| Where to scale (subclass-side, base container) | Try-Fix-2 | ✅ PASS |
| How to scale (no transform, subview stretch) | Try-Fix-3 | ❌ Rejected (design) |
Exhausted: Yes — the only meaningful design axis remaining is "where" to apply the (necessary) transform, and both feasible loci (handler vs subclass) are covered.
Selected Fix
Try-Fix-2 is the strongest alternative to the PR:
- Smallest public API surface: 1 entry (
NeedsContainer.get) vs the PR's 3. - All scaling logic encapsulated in the platform view itself, so the handler is reduced to
NeedsContainer => true+CreatePlatformView() => new MauiProgressView(...). - Eliminates the PR's
ProgressBarContainerView(whoseSetupContainerbody was a copy-paste of the baseViewHandler<,>.SetupContainer). - Passes the same 65/66 tests the PR passes.
Try-Fix-1 is the minimum-diff alternative if the maintainers prefer to keep custom layout logic on the handler rather than introduce a new platform view type:
- 2 public API entries (one fewer than the PR).
- No new platform view subclass.
- Still removes the PR's container subclass and
SetupContaineroverride.
Either alternative would deliver the same fix with strictly less new public surface than the current PR. The PR's ProgressBarContainerView adds defensive LayoutSubviews re-application that the alternatives do not; in practice every sizing path on ProgressBar flows through MAUI's PlatformArrange, so the defensive hook is unused in normal usage, but reviewers may still prefer the PR for that safety margin.
Recommendation: ✅ Suggest the PR author consider Try-Fix-2 as a refactor — same behavior, much smaller public-API impact, and the fix lives at the right abstraction layer (the platform view that has the bug, not a container around it).
📋 Report — Final Recommendation
Comparative Report — PR #35507 candidates
Candidates considered
| # | Candidate | Approach | Test result | Public API entries | Source delta vs base |
|---|---|---|---|---|---|
| 1 | pr | New ProgressBarContainerView : WrapperView + SetupContainer override on handler + PlatformArrange override + CGAffineTransform.MakeScale(1, ratio) on inner UIProgressView |
✅ PASS (gate, 65/66 active, 1 skipped) | 3 (NeedsContainer.get, PlatformArrange, SetupContainer) |
+1 src, +1 platform file (83 lines), +2 PublicAPI, +2 test |
| 2 | pr-plus-reviewer | pr + inline LayoutToBounds helpers into ProgressBarContainerView + extra Progress == 0.5 assertion in the new test |
✅ PASS (inherits — behavior identical) | 3 (same as PR) | +1 src, +1 platform file (~78 lines), +2 PublicAPI, +2 test |
| 3 | try-fix-1 | NeedsContainer => true (base WrapperView) + PlatformArrange override does the scaling inline; no container subclass |
✅ PASS (65/65 active, 0 failed, 1 skipped) | 2 (NeedsContainer.get, PlatformArrange) |
+1 src, +2 PublicAPI, +2 test (PR's test files reused) |
| 4 | try-fix-2 | New MauiProgressView : UIProgressView self-manages bounds + transform via Bounds.set/LayoutSubviews; handler reduces to NeedsContainer => true + CreatePlatformView() => new MauiProgressView(...) |
✅ PASS (65/65 active, 0 failed, 1 skipped) | 1 (NeedsContainer.get only) |
+1 new platform file (~90 lines), +1 src, +2 PublicAPI, +2 test |
| 5 | try-fix-3 | Subclass that stretches internal track UIImageView subviews in LayoutSubviews (no transform) |
❌ Rejected (design analysis — UIProgressView clamps Bounds.Height to intrinsic ~4pt, so the transform is required regardless of where it lives) |
n/a | n/a |
Ranking criteria
Per the task rules, the passing-vs-failing axis dominates: any candidate that failed regression tests MUST rank lower than candidates that passed. After that primary sort, we evaluate on:
- A. Functional correctness (does it fix issue [iOS] ProgressBar and Label don't correctly obey height and width at the core level #7935?)
- B. Public-API surface added
- C. Lines of code added & defensive code locality
- D. Defensive coverage against UIKit-internal layout passes
- E. Reviewer-actionable feedback addressed
- F. Risk of behavioral side-effects elsewhere
Side-by-side evaluation
| Criterion | pr | pr-plus-reviewer | try-fix-1 | try-fix-2 | try-fix-3 |
|---|---|---|---|---|---|
| A. Fixes #7935 | ✅ | ✅ | ✅ | ✅ | ❌ (rejected) |
| Tests pass | ✅ | ✅ (inherited) | ✅ | ✅ | ❌ |
| B. New public API entries (lower = better) | 3 | 3 | 2 | 1 | – |
| C. Lines added (lower = better) | baseline | ≈ baseline | −83 vs PR | −83 +90 ≈ same | – |
D. Defensive LayoutSubviews re-application |
✅ container subclass | ✅ container subclass | ❌ (relies on MAUI re-arrange cycles) | ✅ on platform view directly | – |
| E. Reviewer cleanups applied | – | ✅ 2 of 5 | ✅ 1 (removes container) | ✅ 2 (removes container + extension noise) | – |
| F. Risk to other handlers | low | low | low | low (subclass scoped to MAUI's ProgressBarHandler.CreatePlatformView) |
– |
Rationale walkthrough
-
try-fix-3 → rejected. Per the task rule, this is the lowest-ranked candidate because it does not pass the regression tests (rejected before execution, but classified as "failed to address the regression").
-
try-fix-1 vs try-fix-2. Both pass with the same numbers (65/65 active).
try-fix-2has the smallest public-API surface (1 new entry vs 2 intry-fix-1, 3 inpr/pr-plus-reviewer). It also keeps the defensiveLayoutSubviewsreapplication thattry-fix-1sacrifices. The principal trade-off — sub-typing a UIKit control vs. living on the handler — is decided by the single-responsibility argument: the bug ("aUIProgressViewthat does not honor explicit height") is a property of the platform view, so the platform view is the right place to fix it.try-fix-2strictly dominatestry-fix-1on (B), (D), and (E); it matches on (A), (C), and (F). -
pr / pr-plus-reviewer vs the try-fixes. The PR and its reviewer-cleaned variant are functionally equivalent to
try-fix-2but pay for it with twice as many new public-API entries and a near-duplicatedSetupContaineroverride. The PR'sSetupContainerbody is verifiably byte-for-byte the base implementation except for theWrapperView→ProgressBarContainerViewswap; this is exactly what aprotected internal virtual WrapperView CreateContainerView()factory was invented to avoid, but the PR opens upSetupContainerinstead.pr-plus-reviewerdoes not change this picture — it applies only the behavior-preserving cleanups (inline the extension class, add a fill-ratio assertion). -
Winner =
try-fix-2. It is the only candidate that
(a) passes all regression tests (so it satisfies the pass-vs-fail floor),
(b) reduces the public-API contract to the minimum necessary to opt into a container,
(c) places the fix at the correct abstraction layer (the platform view that actually has the bug),
(d) retains the defensiveLayoutSubviewsre-application that protects against UIKit-internal layout passes,
(e) is strictly equal or better than every other passing candidate on every weighted criterion. -
Caveat on the candidateDiff. The on-disk
try-fix/try-fix-2/fix.diffis incomplete (it contains unrelatedHybridWebView.jsminification noise and the ProgressBar-side of the diff only shows the deletions of the PR-introducedProgressBarContainerViewandSetupContainer/PlatformArrangeoverrides; the addition of theMauiProgressViewsource file is missing from the artifact). The candidateDiff inwinner.jsontherefore reconstructs the full unified diff against the PR base from the design described intry-fix-2/content.md.
Final ranking
- 🥇 try-fix-2 — passes; smallest public-API surface; encapsulated in the platform view; defensive coverage retained.
- 🥈 try-fix-1 — passes; smaller diff than PR; loses one layer of defensive coverage.
- 🥉 pr-plus-reviewer — passes; PR with two minor cleanups; still has 3-entry public-API expansion.
- pr — passes; structurally heavier than necessary.
- try-fix-3 — ❌ rejected (does not address the bug).
Winner: try-fix-2.
kubaflo
requested changes
May 20, 2026
kubaflo
left a comment
kubaflo
left a comment
Contributor
There was a problem hiding this comment.
Could you please check the ai's suggestions?
Author
|
Agreed with the bot. The previous fix worked, but it needed a custom With this shape:
Validation run locally:
I also did a local visual check with explicit 1 pt, 20 pt, 60 pt, and 120 pt ProgressBars. The tracks filled their arranged heights and preserved the 50% progress fill without collapsing back to UIKit’s intrinsic height. |
Contributor
|
/review -b feature/regression-check |
This was referenced May 21, 2026
kubaflo
approved these changes
May 21, 2026
kubaflo
added
s/agent-fix-implemented
PureWeen
pushed a commit
that referenced
this pull request
Jun 2, 2026
### Description of Change Fixes iOS and MacCatalyst `ProgressBar` sizing so the native `UIProgressView` visually honors the MAUI-arranged height. Previously, `ProgressBar` could be arranged with an explicit height, but `UIProgressView` kept its native intrinsic visual height. This meant requested heights like `1`, `100`, and `1000` still produced a native progress view around its default thin height. This change wraps the iOS/MacCatalyst `UIProgressView` in a handler container that owns the MAUI layout bounds. The native progress view remains the public `PlatformView`, is centered inside the container, and is vertically scaled from its measured natural height to the arranged container height during layout. The change also re-enables the shared native bounding-box assertion for `IProgress` and adds a focused iOS/MacCatalyst test that verifies `handler.PlatformView` itself honors explicit sizes. Validation: - MacCatalyst `Category=ProgressBar`: 66 run, 60 passed, 6 ignored - MacCatalyst `Category=Label`: 109 run, 103 passed, 6 ignored - iOS simulator `Category=ProgressBar`: 66 run, 65 passed, 1 ignored - iOS simulator `Category=Label`: 109 run, 108 passed, 1 ignored ### Issues Fixed Fixes #7935
PureWeen
pushed a commit
that referenced
this pull request
Jun 11, 2026
### Description of Change Fixes iOS and MacCatalyst `ProgressBar` sizing so the native `UIProgressView` visually honors the MAUI-arranged height. Previously, `ProgressBar` could be arranged with an explicit height, but `UIProgressView` kept its native intrinsic visual height. This meant requested heights like `1`, `100`, and `1000` still produced a native progress view around its default thin height. This change wraps the iOS/MacCatalyst `UIProgressView` in a handler container that owns the MAUI layout bounds. The native progress view remains the public `PlatformView`, is centered inside the container, and is vertically scaled from its measured natural height to the arranged container height during layout. The change also re-enables the shared native bounding-box assertion for `IProgress` and adds a focused iOS/MacCatalyst test that verifies `handler.PlatformView` itself honors explicit sizes. Validation: - MacCatalyst `Category=ProgressBar`: 66 run, 60 passed, 6 ignored - MacCatalyst `Category=Label`: 109 run, 103 passed, 6 ignored - iOS simulator `Category=ProgressBar`: 66 run, 65 passed, 1 ignored - iOS simulator `Category=Label`: 109 run, 108 passed, 1 ignored ### Issues Fixed Fixes #7935
kubaflo
pushed a commit
that referenced
this pull request
Jun 12, 2026
<!-- Please keep the note below for people who find this PR --> > [!NOTE] > Are you waiting for the changes in this PR to be merged? > It would be very helpful if you could [test the resulting artifacts](https://github.com/dotnet/maui/wiki/Testing-PR-Builds) from this PR and let us know in a comment whether this change resolves your issue. Thank you! <!-- !!!!!!! MAIN IS THE ONLY ACTIVE BRANCH. MAKE SURE THIS PR IS TARGETING MAIN. !!!!!!! --> ### Description of Change Reverts the iOS `ProgressBar` height-scaling behavior introduced in #35507. That PR wrapped `UIProgressView` in a container and vertically scaled it to fill the MAUI-arranged height. While technically correct in isolation, this changes the cross-platform behavior: - **Before #35507**: A `ProgressBar` assigned a parent height of 200 occupies the allocated 200px layout area, but the ProgressBar _track_ is rendered at its native default height — consistent across iOS, Android, and Windows. - **After #35507**: On iOS, the ProgressBar track is stretched to fill the full 200px height, which does **not** match Android or Windows behavior. We also validated this in native iOS: when a height is assigned to the parent container, `UIProgressView` renders at its default intrinsic height and is **not** stretched — confirming that the previous MAUI behavior was the correct cross-platform baseline. ### Impact - All existing iOS ProgressBar device tests are failing after #35507. - The `ProgressBar_ProgressToMethod_VerifyVisualState` test visually demonstrates the inconsistency (screenshots attached ). ### Screenshots | Platform | Before #35507 (expected) | After #35507 (regression) | |----------|--------------------------|---------------------------| | iOS | <img width="1124" height="2286" alt="ProgressBar_ProgressToMethod_VerifyVisualState" src="https://github.com/user-attachments/assets/06b475ef-955a-4ad3-bdb7-99164a6b17f4" /> | <img width="1124" height="2286" alt="ProgressBar_ProgressToMethod_VerifyVisualState" src="https://github.com/user-attachments/assets/444c9fa7-663d-416b-b95e-d7d01066c32f" /> | | Mac | <img width="789" height="563" alt="ProgressBar_ProgressToMethod_VerifyVisualState (2)" src="https://github.com/user-attachments/assets/aa89d1ec-cb19-4ed3-860a-1f326f2f100e" /> | <img width="789" height="563" alt="ProgressBar_ProgressToMethod_VerifyVisualState" src="https://github.com/user-attachments/assets/0c068902-d8d9-4a74-b37d-c0e1f2a5f6fd" /> | | Windows | <img width="1010" height="729" alt="ProgressBar_ProgressToMethod_VerifyVisualState" src="https://github.com/user-attachments/assets/669aed20-11af-4b2b-b9b0-286bc68ddd8b" /> | N/A | | Android | <img width="1080" height="1735" alt="ProgressBar_ProgressToMethod_VerifyVisualState (1)" src="https://github.com/user-attachments/assets/679ade5f-2a30-4ac7-b2df-057d799ac1af" /> | N/A | cc : @AdamEssenmacher <!-- Are you targeting main? All PRs should target the main branch unless otherwise noted. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Fixes iOS and MacCatalyst
ProgressBarsizing so the nativeUIProgressViewvisually honors the MAUI-arranged height.Previously,
ProgressBarcould be arranged with an explicit height, butUIProgressViewkept its native intrinsic visual height. This meant requested heights like1,100, and1000still produced a native progress view around its default thin height.This change wraps the iOS/MacCatalyst
UIProgressViewin a handler container that owns the MAUI layout bounds. The native progress view remains the publicPlatformView, is centered inside the container, and is vertically scaled from its measured natural height to the arranged container height during layout.The change also re-enables the shared native bounding-box assertion for
IProgressand adds a focused iOS/MacCatalyst test that verifieshandler.PlatformViewitself honors explicit sizes.Validation:
Category=ProgressBar: 66 run, 60 passed, 6 ignoredCategory=Label: 109 run, 103 passed, 6 ignoredCategory=ProgressBar: 66 run, 65 passed, 1 ignoredCategory=Label: 109 run, 108 passed, 1 ignoredIssues Fixed
Fixes #7935